Repository navigation
Override DbConnection.BeginTransactionAsync on SqlConnection #3248
Description
Is your feature request related to a problem? Please describe.
This triggers CA1849 if the rule is enabled (included in the "All" ruleset) and called within an async method.
await using var transaction = connection.BeginTransaction();The base DbConnection class provides BeginTransactionAsync, but since it doesn't have an implementation on SqlConnection, the return type is DbTransaction rather than SqlTransaction, which requires a cast to assign the transaction to a command later.
await using var transaction = (SqlTransaction)await connection.BeginTransactionAsync(cancellationToken);
await using var command = connection.CreateCommand();
command.Transaction = transaction;Describe the solution you'd like
Cover the base BeginTransactionAsync with one that returns SqlTransaction when called directly on a SqlConnection instance.
await using var transaction = await connection.BeginTransactionAsync(cancellationToken);
await using var command = connection.CreateCommand();
command.Transaction = transaction;Describe alternatives you've considered
It can be worked around with a cast, but that's writing code that really shouldn't be there.
Additional context
I'd make a PR for this myself but I'm somewhat intimidated working on such a large, unfamiliar project 😅
Reacted by Malcolm Daigle
Activity
[-]Improve Compatiblity with Warning CA1849 on BeginTransaction[/-][+]Override DbConnection.BeginTransactionAsync on SqlConnection[/+]mdaigle commentedon Mar 27, 2025
Thanks @RyanLamansky, I've added it to our backlog!
roji commentedon Mar 27, 2025
Duplicate of #113, no?
mdaigle commentedon Mar 27, 2025
Thanks @roji, yes, I'll close this in favor of 113.
RyanLamansky commentedon Mar 28, 2025
Ah, it's part of an old issue then. I had searched specifically for
BeginTransactionAsyncand nothing came back.