Visitar URL original
Merge | Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx by MichelZ · Pull Request #2982 · dotnet/SqlClient · GitHub
Skip to content

Merge | Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx - #2982

Merged
benrr101 merged 14 commits into
dotnet:mainfrom
MichelZ:tdsparser-align-2
Nov 26, 2024
Merged

Merge | Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx#2982
benrr101 merged 14 commits into
dotnet:mainfrom
MichelZ:tdsparser-align-2

Conversation

@MichelZ

@MichelZ MichelZ commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

Part of #2953

Aligning Task return, bringing over ArrayPool usage and aligning IsColumnEncryptionSupported changes between netcore and netfx

@codecov

codecov Bot commented Nov 6, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.67568% with 18 lines in your changes missing coverage. Please review.

Project coverage is 72.46%. Comparing base (4bc9ee6) to head (43a4fd6).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 78.26% 15 Missing ⚠️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2982      +/-   ##
==========================================
- Coverage   72.50%   72.46%   -0.04%     
==========================================
  Files         288      288              
  Lines       59529    59507      -22     
==========================================
- Hits        43159    43122      -37     
- Misses      16370    16385      +15
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.39% <40.00%> (-0.05%) ⬇️
netfx 70.90% <78.26%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelZ MichelZ mentioned this pull request Nov 7, 2024
Closed
benrr101
benrr101 requested changes Nov 14, 2024
View reviewed changes

@benrr101 benrr101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think this is a decent change. I'm hesitant to start touching things in the TdsParser, but these changes seem to be pretty constrained. Only a few comments. Not sure about the feasibility of using stackalloc instead of array pool in the last commit.

Comment thread src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs Resolved
@MichelZ
MichelZ requested a review from benrr101 November 19, 2024 07:50
@MichelZ MichelZ changed the title Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx Merge | Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx Nov 24, 2024
@mdaigle mdaigle added the Common Project 🚮 Things that relate to the common project project label Nov 25, 2024
@benrr101
benrr101 merged commit d4d5eba into dotnet:main Nov 26, 2024
@cheenamalhotra cheenamalhotra modified the milestones: 6.0.0, 6.1-preview1 Apr 30, 2025
This was referenced Jul 25, 2025
Open
Merged
Merged
Merged
This was referenced Sep 13, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 23, 2026
Merged
Merged
Merged
Closed
Closed
Closed
This was referenced Oct 5, 2026
Closed
Closed
This was referenced Oct 13, 2026
Closed
Closed
Closed
Closed
This was referenced Oct 21, 2026
Closed
Closed
Closed
Closed
This was referenced Nov 2, 2026
Closed
Closed
Open
This was referenced Nov 9, 2026
Open
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benrr101 benrr101 benrr101 approved these changes
@David-Engel David-Engel David-Engel approved these changes

Assignees

No one assigned

Labels

Common Project 🚮 Things that relate to the common project project

Projects

None yet

Milestone

6.1-preview1

Development

Successfully merging this pull request may close these issues.

5 participants

@MichelZ @benrr101 @David-Engel @mdaigle @cheenamalhotra