Visitar URL original
Question: Any objections to only allowing "rebase" commits in the repo? · Issue #3 · eclipse-dash/nodejs-wrapper · GitHub
Skip to content

Question: Any objections to only allowing "rebase" commits in the repo? #3

Open

Description

@marcdumais-work

ATM, "merge commits" are enabled and used in this repository. Would there be an objection to stop using them here, in favor of using the "rebase"-type PR commits?

I ask because of the publish/release automation work I am doing - one potential way forward is to include/detect a keyword in the HEAD commit (of a PR) title, to trigger a new automated release. However it seems this mechanism would break is a PR is merged using "merge-commit", that adds a commit on top.

WDYT? I can submit a PR to modify this if the proposal is acceptable.

Activity

  1. marcdumais-work commented on Feb 20, 2024

    @marcdumais-work
    ContributorAuthor

    BTW, I am willing to rework the commits of any of my PRs (e.g. squash them) if requested in a review, to keep a relatively tidy history.

  2. waynebeaton commented on Nov 18, 2024

    @waynebeaton
    Contributor

    Sorry for the long delay. I must have missed the notification that this issue had been created.

    I have no problem with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions