Are branche names like "something-gcc14" legit ? #194

Hi,

I am the administrator of a gerrit server in my company.
One of my user created some branches like "something-gcc14", "something-gcc15", etc...
He was unable to push one of these branch ("something-gcc14").
The gerrit server respond an internal error:

org.eclipse.jgit.errors.AmbiguousObjectException: Object abbreviation cc14 is ambiguous
at org.eclipse.jgit.lib.Repository.resolveAbbreviation(Repository.java:924)
at org.eclipse.jgit.lib.Repository.resolveSimple(Repository.java:862)
at org.eclipse.jgit.lib.Repository.resolve(Repository.java:817)
at org.eclipse.jgit.lib.Repository.resolve(Repository.java:473)
at com.google.gerrit.server.git.receive.ReceiveCommits.parseCreate(ReceiveCommits.java:1495)
at com.google.gerrit.server.git.receive.ReceiveCommits.parseRegularCommand(ReceiveCommits.java:1332)
at com.google.gerrit.server.git.receive.ReceiveCommits.handleRegularCommands(ReceiveCommits.java:869)
at com.google.gerrit.server.git.receive.ReceiveCommits.processCommandsUnsafe(ReceiveCommits.java:789)
at com.google.gerrit.server.git.receive.ReceiveCommits.processCommands(ReceiveCommits.java:699)
at com.google.gerrit.server.git.receive.AsyncReceiveCommits.lambda$preReceive$2(AsyncReceiveCommits.java:386)

After investigation, it seems that the root causes were:

• a commit in his repo start with "cc14"
• the implementation of "resolveSimple" in class https://github.com/eclipse-jgit/jgit/blob/master/org.eclipse.jgit/src/org/eclipse/jgit/lib/Repository.java

In this case, "something-gcc14" was interpreted as a sha1, and not a branch name.

Does it means that branch names like "something-gcc15" are not legit ?