Repository navigation
Add new coordinate and metric classes #525
Description
🐞 What bugs you?
The core modules of EinsteinPy are well-integrated, after #512 & #521. Now, we can add more metric classes to the module, in all usual coordinates, corresponding to the metric. This will be an ongoing issue, tracking new coordinate and metric additions, quite similar to the issue for symbolic module (#309). Related issues are #15 and #16.
🎯 Goal
Add new metric and coordinate classes to enhance the numerical relativity toolkit, offered by EinsteinPy. An important addition would be a class for Kerr-Schild Coordinates in einsteinpy.coordinates and Kerr-Schild forms of the vacuum solutions (Schwarzschild, Kerr and KerrNewman classes, as of now) in einsteinpy.metric.
💡 Possible solutions
https://arxiv.org/pdf/0904.4184.pdf is a good source for many metric classes, along with their corresponding coordinates. More resource suggestions are welcome.
📋 Steps to solve the problem
- Comment below, which metric or coordinate, you've started working on.
- Add, commit, push your changes.
- Submit a pull request and add this in comments -
Addresses #<put issue number here> | Adds support for <put metric or coordinate name here>. - Ask for a review in comments section of pull request.
- Celebrate your contribution to this project 🎉
Activity
QMrpy commentedon Jan 21, 2021
I have started working on adding Eddington-Finkelstein Coordinates, and Kerr-Schild Coordinates. Also, I will be adding Reissner-Nordstrom Metric to EinsteinPy.
JeS24 commentedon Jan 21, 2021
@QMrpy Can you join either our Gitter or Riot room? We can discuss this there.
loganshamberger commentedon Dec 30, 2021
@JeS24 If this issue is still open, I'd like to contribute to this. Are there metric classes or coordinates that are needed? I was thinking to start with the cosmic string in Schwarzschild as a first issue, but can do others if they are needed. I can also do deSitter
shreyasbapat commentedon Jan 6, 2022
Hi @loganshamberger ! You are welcome to contribute whatever you can!
LuNoX commentedon Jan 12, 2023
Hello! What's the status of this issue? Do you still need some help? I'd like to contribute :)
JeS24 commentedon Jan 13, 2023
@LuNoX Hi. This is an ongoing issue, where we'll be tracking many metric & coordinate system additions to the library. Feel free to contribute to it. And if you face any issues, you can drop a message either here or in EPy's Gitter or Element (Matrix) chat group (Check README.md for the links).
AlnesrAltair commentedon Sep 13, 2024
Hey! Is this still active? I would be happy to contribute.
JeS24 commentedon Sep 13, 2024
Hi @AlnesrAltair. This issue is active. Feel free to contribute.
AlnesrAltair commentedon Sep 23, 2024
Thanks! I'll start with something simple and see if I can add a Reissner-Nordstrom metric, following the pattern of the Schwarzschild metric module