Visitar URL original
node#64894: worker: add support for Web Workers · electron/electron@f7c8c22 · GitHub
Skip to content

Commit f7c8c22

Browse files
committed
node#64894: worker: add support for Web Workers
Node.js 26 adds a Web Worker API and its pre-execution deletes globalThis.Worker unless --experimental-web-worker is set, without checking noBrowserGlobals, so renderers and web workers with Node integration lost Blink's Worker. Pass the flag in those processes, as is already done for --experimental-eventsource; Node's own Worker is not installed under kNoBrowserGlobals. Ref: nodejs/node#64894 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU
1 parent cb95851 commit f7c8c22

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

‎shell/common/node_bindings.cc‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -670,15 +670,17 @@ std::vector<std::string> NodeBindings::ParseNodeCliFlags() {
670670
args.push_back(option);
671671
}
672672

673-
// Node's setupEventsource() in lib/internal/process/pre_execution.js
674-
// deletes globalThis.EventSource when --experimental-eventsource is not
675-
// set, and unlike its sibling setup functions it does not check
676-
// noBrowserGlobals. Pass the flag so Blink's EventSource is left alone;
677-
// Node's own undici EventSource is never installed under
678-
// kNoBrowserGlobals so there is no conflict.
673+
// Node's setupEventsource() and removeWebWorkersIfDisabled() in
674+
// lib/internal/process/pre_execution.js delete globalThis.EventSource and
675+
// globalThis.Worker when --experimental-eventsource and
676+
// --experimental-web-worker are not set, and unlike their sibling setup
677+
// functions they do not check noBrowserGlobals. Pass the flags so Blink's
678+
// EventSource and Worker are left alone; Node's own EventSource and Worker
679+
// are never installed under kNoBrowserGlobals so there is no conflict.
679680
if (browser_env_ == BrowserEnvironment::kRenderer ||
680681
browser_env_ == BrowserEnvironment::kWorker) {
681682
args.push_back("--experimental-eventsource");
683+
args.push_back("--experimental-web-worker");
682684
}
683685

684686
return args;

0 commit comments

Comments
 (0)