Visitar URL original

make sure sync cannot block reboot · enterdevstudio/cloudstack@43a9eb4 · GitHub

Repository navigation

Commit 43a9eb4

authored and

Daan Hoogland

committed

make sure sync cannot block reboot

The recent discussed improvement has the risk that if 'sync' hangs, the reboot may be delayed in the same way as the 'reboot' command would do. To work around, we're adding a 5 second timeout. If it cannot sync in 5 seconds, it will not succeed anyway and we should proceed the reset. @snuf: Could we use your OVM3 heartbeat script for other hypervisors as well? One way to do it seems like a nice idea :-)

1 parent b236619 commit 43a9eb4Copy full SHA for 43a9eb4

1 file changed

scripts/vm/hypervisor/kvm
- kvmheartbeat.sh

`‎scripts/vm/hypervisor/kvm/kvmheartbeat.sh‎`

-Original file line number
+Diff line change
 elif [ "$cflag" == "1" ]
 then
   /usr/bin/logger -t heartbeat "kvmheartbeat.sh rebooted system because it was unable to write the heartbeat to the storage."
 -  sync
 +  sync &
 +  sleep 5
   echo b > /proc/sysrq-trigger
   exit $?
 else

Comments

(0)