Visitar URL original
Cleanup · errbit/errbit_github_plugin@7854256 · GitHub
Skip to content

Commit 7854256

Browse files
committed
Cleanup
1 parent 1ad6514 commit 7854256

2 files changed

Lines changed: 10 additions & 16 deletions

File tree

‎lib/errbit_github_plugin/issue_tracker.rb‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,15 @@ def self.fields
3333
end
3434

3535
def self.icons
36-
@icons ||= {
36+
{
3737
create: [
38-
'image/png', ErrbitGithubPlugin.read_static_file('github_create.png')
38+
'image/png', 'errbit_github_plugin/github_create.png'
3939
],
4040
goto: [
41-
'image/png', ErrbitGithubPlugin.read_static_file('github_goto.png'),
41+
'image/png', 'errbit_github_plugin/github_goto.png'
4242
],
4343
inactive: [
44-
'image/png', ErrbitGithubPlugin.read_static_file('github_inactive.png'),
44+
'image/png', 'errbit_github_plugin/github_inactive.png'
4545
]
4646
}
4747
end

‎spec/issue_tracker_spec.rb‎

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,24 +20,18 @@
2020
describe '.icons' do
2121

2222
it 'puts create icon onto the icons' do
23-
expect(described_class.icons[:create][0]).to eq 'image/png'
24-
expect(
25-
described_class.icons[:create][1]
26-
).to eq ErrbitGithubPlugin.read_static_file('github_create.png')
23+
expect(described_class.icons[:create][0]).to eq('image/png')
24+
expect(described_class.icons[:create][1]).to eq('errbit_github_plugin/github_create.png')
2725
end
2826

2927
it 'puts goto icon onto the icons' do
30-
expect(described_class.icons[:goto][0]).to eq 'image/png'
31-
expect(
32-
described_class.icons[:goto][1]
33-
).to eq ErrbitGithubPlugin.read_static_file('github_goto.png')
28+
expect(described_class.icons[:goto][0]).to eq('image/png')
29+
expect(described_class.icons[:goto][1]).to eq('errbit_github_plugin/github_goto.png')
3430
end
3531

3632
it 'puts inactive icon onto the icons' do
37-
expect(described_class.icons[:inactive][0]).to eq 'image/png'
38-
expect(
39-
described_class.icons[:inactive][1]
40-
).to eq ErrbitGithubPlugin.read_static_file('github_inactive.png')
33+
expect(described_class.icons[:inactive][0]).to eq('image/png')
34+
expect(described_class.icons[:inactive][1]).to eq('errbit_github_plugin/github_inactive.png')
4135
end
4236
end
4337

0 commit comments

Comments
 (0)