Improve exception tests

Maybe we should change the way we test exceptions (see #476) to always use a context manger as this way is easier to understand.

def test_it(self):
    self.assertRaises(SomeException, do_something, 42, True)

def test_it_with_context(self):
    with self.assertRaises(SomeException):
        do_something(42, True)

Steps

update old tests
document this in the readme for new exercises

I like the idea; it improves readability significantly.

Maybe we could take advantage of the Hacktoberfest momentum and create another wave of issues for this?

@cmccandless

good idea, @cmccandless!
It would be somewhat hard to create a list of all affected exercises I think

I can begin to make a list.

@cmccandless

@cmccandless that would be awesome!

Once we have a list we can create separate issues for each exercise

Affected exercises:

As there is already a large amount of pull issues and pull requests designated for Hacktoberfest, I went ahead and created a single pull request for this (#945).

@cmccandless

@cmccandless, wow, thanks a lot and sorry for the delay in review

Improve exception tests by making use of Context Managers to resolve #…

bowling: use context manager form for assertRaises (RE: #477)

Navigation Menu

Repository navigation

Improve exception tests #477

Steps

Affected exercises:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Improve exception tests #477

Description

Steps

Activity

cmccandless commented on Oct 5, 2017

ilya-khadykin commented on Oct 5, 2017

cmccandless commented on Oct 5, 2017

ilya-khadykin commented on Oct 5, 2017

cmccandless commented on Oct 5, 2017

Affected exercises:

cmccandless commented on Oct 17, 2017

ilya-khadykin commented on Oct 17, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions