Visitar URL original
Fix codemod crashing on aliases in inline fragments · meta/relay@002f9ed · GitHub
Skip to content

Commit 002f9ed

Browse files
gordyf-metafacebook-github-bot
authored andcommitted
Fix codemod crashing on aliases in inline fragments
Reviewed By: captbaritone Differential Revision: D69204227 fbshipit-source-id: 4b7c7a5ddb66048fd0394585ff93a55c8b5ecd99
1 parent ac7a7c7 commit 002f9ed

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎compiler/crates/relay-codemod/src/codemod.rs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@ pub async fn run_codemod(
5555
}
5656
}
5757
AvailableCodemod::RemoveUnnecessaryRequiredDirectives => {
58-
disallow_required_on_non_null_field(&programs.source).unwrap_or_default()
58+
match disallow_required_on_non_null_field(&programs.source) {
59+
Ok(e) => e,
60+
Err(e) => panic!("{:?}", e),
61+
}
5962
}
6063
})
6164
.collect::<Vec<_>>();

‎compiler/crates/relay-transforms/src/validations/disallow_required_on_non_null_field.rs‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ use lazy_static::lazy_static;
2525
use schema::SDLSchema;
2626
use schema::Schema;
2727

28+
use crate::fragment_alias_directive;
2829
use crate::required_directive;
2930
use crate::ValidationMessageWithData;
3031
use crate::CATCH_DIRECTIVE_NAME;
@@ -51,7 +52,8 @@ pub fn disallow_required_on_non_null_field(
5152
// required_directive transform. This validation is run on untransformed
5253
// versions of IR both in the LSP and as a codemod, so we apply the transform
5354
// ourselves locally.
54-
let program = required_directive(program)?;
55+
let program = fragment_alias_directive(program, &common::FeatureFlag::Disabled)?;
56+
let program = required_directive(&program)?;
5557
let mut validator = DisallowRequiredOnNonNullField::new(&program.schema);
5658
validator.validate_program(&program)?;
5759
Ok(validator.warnings)

0 commit comments

Comments
 (0)