Visitar URL original
chore: Build wheels fix (#4957) · feast-dev/feast@44ec146 · GitHub
Skip to content

Commit 44ec146

Browse files
tchughesivtchughesiv
authored
chore: Build wheels fix (#4957)
dev Signed-off-by: Tommy Hughes <tohughes@redhat.com>
1 parent 301ef9a commit 44ec146

1 file changed

Lines changed: 29 additions & 38 deletions

File tree

‎.github/workflows/build_wheels.yml‎

Lines changed: 29 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -4,40 +4,11 @@ name: build wheels
44
# Developers who are starting a new release should use this workflow to ensure wheels will be built correctly.
55
# Devs should check out their fork, add a tag to the last master commit on their fork, and run the release off of their fork on the added tag to ensure wheels will be built correctly.
66
on:
7-
workflow_dispatch:
7+
workflow_dispatch: # Allows manual trigger of the workflow
88
inputs:
9-
release_version:
10-
description: 'The release version to use (e.g., v1.2.3)'
11-
required: true
12-
type: string
13-
highest_semver_tag:
14-
description: 'The highest semantic version tag without the "v" prefix (e.g., 1.2.3)'
15-
required: true
16-
type: string
17-
version_without_prefix:
18-
description: 'The release version to use without "v" (e.g., 1.2.3)'
19-
required: true
20-
type: string
21-
token:
22-
description: 'Personal Access Token'
23-
required: true
24-
default: ""
25-
type: string
26-
27-
workflow_call:
28-
inputs:
29-
release_version:
30-
description: 'The release version to use (e.g., v1.2.3)'
31-
required: true
32-
type: string
33-
highest_semver_tag:
34-
description: 'The highest semantic version tag without the "v" prefix (e.g., 1.2.3)'
35-
required: true
36-
type: string
37-
version_without_prefix:
38-
description: 'The release version to use without "v" (e.g., 1.2.3)'
39-
required: true
40-
type: string
9+
custom_version: # Optional input for a custom version
10+
description: 'Custom version to publish (e.g., v1.2.3) -- only edit if you know what you are doing'
11+
required: false
4112
token:
4213
description: 'Personal Access Token'
4314
required: true
@@ -62,9 +33,14 @@ jobs:
6233
registry-url: 'https://registry.npmjs.org'
6334
- name: Build UI
6435
run: make build-ui
36+
- id: get-version
37+
uses: ./.github/actions/get-semantic-release-version
38+
with:
39+
custom_version: ${{ github.event.inputs.custom_version }}
40+
token: ${{ github.event.inputs.token }}
6541
- name: Build wheels
6642
env:
67-
VERSION: ${{ github.event.inputs.release_version }}
43+
VERSION: ${{ steps.get-version.outputs.release_version }}
6844
run: |
6945
git fetch --tags
7046
git checkout ${VERSION}
@@ -91,9 +67,14 @@ jobs:
9167
with:
9268
node-version-file: './ui/.nvmrc'
9369
registry-url: 'https://registry.npmjs.org'
70+
- id: get-version
71+
uses: ./.github/actions/get-semantic-release-version
72+
with:
73+
custom_version: ${{ github.event.inputs.custom_version }}
74+
token: ${{ github.event.inputs.token }}
9475
- name: Build and install dependencies
9576
env:
96-
VERSION: ${{ github.event.inputs.release_version }}
77+
VERSION: ${{ steps.get-version.outputs.release_version }}
9778
# There's a `git restore` in here because `make install-go-ci-dependencies` is actually messing up go.mod & go.sum.
9879
run: |
9980
git fetch --tags
@@ -127,10 +108,15 @@ jobs:
127108
uses: docker/setup-qemu-action@v1
128109
- name: Set up Docker Buildx
129110
uses: docker/setup-buildx-action@v1
111+
- id: get-version
112+
uses: ./.github/actions/get-semantic-release-version
113+
with:
114+
custom_version: ${{ github.event.inputs.custom_version }}
115+
token: ${{ github.event.inputs.token }}
130116
- name: Build image
131117
env:
132-
VERSION_WITHOUT_PREFIX: ${{ github.event.inputs.version_without_prefix }}
133-
RELEASE_VERSION: ${{ github.event.inputs.release_version }}
118+
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
119+
RELEASE_VERSION: ${{ steps.get-version.outputs.release_version }}
134120
run: |
135121
echo "Building docker image for ${{ matrix.component }} with version $VERSION_WITHOUT_PREFIX and release version $RELEASE_VERSION"
136122
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX}
@@ -187,9 +173,14 @@ jobs:
187173
if: ${{ matrix.from-source }}
188174
run: pip install dist/*tar.gz
189175
# Validate that the feast version installed is not development and is the correct version of the tag we ran it off of.
176+
- id: get-version
177+
uses: ./.github/actions/get-semantic-release-version
178+
with:
179+
custom_version: ${{ github.event.inputs.custom_version }}
180+
token: ${{ github.event.inputs.token }}
190181
- name: Validate Feast Version
191182
env:
192-
VERSION_WITHOUT_PREFIX: ${{ github.event.inputs.version_without_prefix }}
183+
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
193184
run: |
194185
feast version
195186
if ! VERSION_OUTPUT=$(feast version); then

0 commit comments

Comments
 (0)