Visitar URL original
fix · feast-dev/feast@5abbec2 · GitHub
Skip to content

Commit 5abbec2

Browse files
franciscojavierarceofranciscojavierarceo
committed
fix
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
1 parent e5f074e commit 5abbec2

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

‎sdk/python/feast/feature_store.py‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,7 +1019,9 @@ def apply(
10191019

10201020
# Create ODFV with same transformation logic and correct mode
10211021
# Include both FeatureViews and RequestSources in sources
1022-
sources_list: List[Union[FeatureView, RequestSource]] = list(fv.source_views or [])
1022+
sources_list: List[Union[FeatureView, RequestSource]] = list(
1023+
fv.source_views or []
1024+
)
10231025
if hasattr(fv, "source_request_sources") and fv.source_request_sources:
10241026
sources_list.extend(fv.source_request_sources.values())
10251027

@@ -1294,7 +1296,9 @@ def get_historical_features(
12941296
# Handle FeatureViews with feature_transformation for historical retrieval
12951297
# These are supported by extracting their source views and applying transformations later
12961298
regular_feature_views: List[Union[FeatureView, OnDemandFeatureView]] = []
1297-
unified_transformation_views: List[Tuple[Union[FeatureView, OnDemandFeatureView], List[str]]] = []
1299+
unified_transformation_views: List[
1300+
Tuple[Union[FeatureView, OnDemandFeatureView], List[str]]
1301+
] = []
12981302
source_feature_views: List[Union[FeatureView, OnDemandFeatureView]] = []
12991303

13001304
# Separate FeatureViews with transformations from regular ones

‎sdk/python/feast/utils.py‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -529,8 +529,11 @@ def _group_feature_refs(
529529
# Redirect if:
530530
# 1. Feature exists in original view but online serving is disabled, OR
531531
# 2. Feature doesn't exist in original view at all
532-
if (feat_name in feature_names_in_original
533-
and hasattr(original_view, 'online') and not original_view.online):
532+
if (
533+
feat_name in feature_names_in_original
534+
and hasattr(original_view, "online")
535+
and not original_view.online
536+
):
534537
should_redirect = True
535538
elif feat_name not in feature_names_in_original:
536539
should_redirect = True

0 commit comments

Comments
 (0)