Visitar URL original
address reviews · feast-dev/feast@880895c · GitHub
Skip to content

Commit 880895c

Browse files
VperiodtVperiodt
committed
address reviews
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
1 parent fca8d5e commit 880895c

14 files changed

Lines changed: 293 additions & 106 deletions

File tree

‎.secrets.baseline‎

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎infra/feast-operator/api/v1/featurestore_types.go‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ type OpenLineageConsumerConfig struct {
145145
// MlflowConfig enables MLflow experiment tracking integration for Feast.
146146
// When enabled, feature retrieval metadata is automatically logged to MLflow runs
147147
// and the Feast UI displays lineage from feature views to registered models.
148+
// +kubebuilder:validation:XValidation:rule="!has(self.extraConfig) || !('enabled' in self.extraConfig) && !('tracking_uri' in self.extraConfig) && !('ui_url' in self.extraConfig) && !('tracking_auth' in self.extraConfig) && !('auto_log' in self.extraConfig) && !('auto_log_entity_df' in self.extraConfig) && !('entity_df_max_rows' in self.extraConfig) && !('log_operations' in self.extraConfig) && !('ops_experiment_suffix' in self.extraConfig)",message="extraConfig must not contain keys that duplicate typed fields (enabled, tracking_uri, ui_url, tracking_auth, auto_log, auto_log_entity_df, entity_df_max_rows, log_operations, ops_experiment_suffix); use the corresponding spec fields instead."
148149
type MlflowConfig struct {
149150
// Enable MLflow integration.
150151
Enabled bool `json:"enabled"`
@@ -180,6 +181,12 @@ type MlflowConfig struct {
180181
// Defaults to "-feast-ops".
181182
// +optional
182183
OpsExperimentSuffix *string `json:"opsExperimentSuffix,omitempty"`
184+
// Authentication method used by Feast pods when calling the MLflow tracking
185+
// server. Common values: "kubernetes-namespaced" (token-based, default on
186+
// OpenShift AI), "basic", "bearer", or "" (no auth for local/dev).
187+
// Defaults to "kubernetes-namespaced".
188+
// +optional
189+
TrackingAuth *string `json:"trackingAuth,omitempty"`
183190
// ExtraConfig holds additional MLflow key-value settings written inline into
184191
// the mlflow block of feature_store.yaml. Boolean and integer string values
185192
// are coerced to native YAML types. Keys must be valid Feast MlflowConfig

‎infra/feast-operator/api/v1/zz_generated.deepcopy.go‎

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎infra/feast-operator/bundle/manifests/feast-operator.clusterserviceversion.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ metadata:
147147
}
148148
]
149149
capabilities: Basic Install
150-
createdAt: "2026-07-23T09:29:46Z"
150+
createdAt: "2026-08-03T18:09:16Z"
151151
operators.operatorframework.io/builder: operator-sdk-v1.41.0
152152
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4
153153
name: feast-operator.v0.65.0

‎infra/feast-operator/bundle/manifests/feast.dev_featurestores.yaml‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -898,6 +898,11 @@ spec:
898898
Suffix appended to the project name for the operations experiment.
899899
Defaults to "-feast-ops".
900900
type: string
901+
trackingAuth:
902+
description: |-
903+
Authentication method used by Feast pods when calling the MLflow tracking
904+
server.
905+
type: string
901906
trackingUri:
902907
description: |-
903908
MLflow tracking server URI. When omitted, the operator auto-discovers
@@ -910,6 +915,18 @@ spec:
910915
required:
911916
- enabled
912917
type: object
918+
x-kubernetes-validations:
919+
- message: extraConfig must not contain keys that duplicate typed
920+
fields (enabled, tracking_uri, ui_url, tracking_auth, auto_log,
921+
auto_log_entity_df, entity_df_max_rows, log_operations, ops_experiment_suffix);
922+
use the corresponding spec fields instead.
923+
rule: '!has(self.extraConfig) || !(''enabled'' in self.extraConfig)
924+
&& !(''tracking_uri'' in self.extraConfig) && !(''ui_url'' in
925+
self.extraConfig) && !(''tracking_auth'' in self.extraConfig)
926+
&& !(''auto_log'' in self.extraConfig) && !(''auto_log_entity_df''
927+
in self.extraConfig) && !(''entity_df_max_rows'' in self.extraConfig)
928+
&& !(''log_operations'' in self.extraConfig) && !(''ops_experiment_suffix''
929+
in self.extraConfig)'
913930
openlineage:
914931
description: |-
915932
OpenLineage enables OpenLineage data lineage tracking for Feast operations.
@@ -7272,6 +7289,11 @@ spec:
72727289
Suffix appended to the project name for the operations experiment.
72737290
Defaults to "-feast-ops".
72747291
type: string
7292+
trackingAuth:
7293+
description: |-
7294+
Authentication method used by Feast pods when calling the MLflow tracking
7295+
server.
7296+
type: string
72757297
trackingUri:
72767298
description: |-
72777299
MLflow tracking server URI. When omitted, the operator auto-discovers
@@ -7284,6 +7306,18 @@ spec:
72847306
required:
72857307
- enabled
72867308
type: object
7309+
x-kubernetes-validations:
7310+
- message: extraConfig must not contain keys that duplicate typed
7311+
fields (enabled, tracking_uri, ui_url, tracking_auth, auto_log,
7312+
auto_log_entity_df, entity_df_max_rows, log_operations, ops_experiment_suffix);
7313+
use the corresponding spec fields instead.
7314+
rule: '!has(self.extraConfig) || !(''enabled'' in self.extraConfig)
7315+
&& !(''tracking_uri'' in self.extraConfig) && !(''ui_url''
7316+
in self.extraConfig) && !(''tracking_auth'' in self.extraConfig)
7317+
&& !(''auto_log'' in self.extraConfig) && !(''auto_log_entity_df''
7318+
in self.extraConfig) && !(''entity_df_max_rows'' in self.extraConfig)
7319+
&& !(''log_operations'' in self.extraConfig) && !(''ops_experiment_suffix''
7320+
in self.extraConfig)'
72877321
openlineage:
72887322
description: |-
72897323
OpenLineage enables OpenLineage data lineage tracking for Feast operations.

‎infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -898,6 +898,11 @@ spec:
898898
Suffix appended to the project name for the operations experiment.
899899
Defaults to "-feast-ops".
900900
type: string
901+
trackingAuth:
902+
description: |-
903+
Authentication method used by Feast pods when calling the MLflow tracking
904+
server.
905+
type: string
901906
trackingUri:
902907
description: |-
903908
MLflow tracking server URI. When omitted, the operator auto-discovers
@@ -910,6 +915,18 @@ spec:
910915
required:
911916
- enabled
912917
type: object
918+
x-kubernetes-validations:
919+
- message: extraConfig must not contain keys that duplicate typed
920+
fields (enabled, tracking_uri, ui_url, tracking_auth, auto_log,
921+
auto_log_entity_df, entity_df_max_rows, log_operations, ops_experiment_suffix);
922+
use the corresponding spec fields instead.
923+
rule: '!has(self.extraConfig) || !(''enabled'' in self.extraConfig)
924+
&& !(''tracking_uri'' in self.extraConfig) && !(''ui_url'' in
925+
self.extraConfig) && !(''tracking_auth'' in self.extraConfig)
926+
&& !(''auto_log'' in self.extraConfig) && !(''auto_log_entity_df''
927+
in self.extraConfig) && !(''entity_df_max_rows'' in self.extraConfig)
928+
&& !(''log_operations'' in self.extraConfig) && !(''ops_experiment_suffix''
929+
in self.extraConfig)'
913930
openlineage:
914931
description: |-
915932
OpenLineage enables OpenLineage data lineage tracking for Feast operations.
@@ -7272,6 +7289,11 @@ spec:
72727289
Suffix appended to the project name for the operations experiment.
72737290
Defaults to "-feast-ops".
72747291
type: string
7292+
trackingAuth:
7293+
description: |-
7294+
Authentication method used by Feast pods when calling the MLflow tracking
7295+
server.
7296+
type: string
72757297
trackingUri:
72767298
description: |-
72777299
MLflow tracking server URI. When omitted, the operator auto-discovers
@@ -7284,6 +7306,18 @@ spec:
72847306
required:
72857307
- enabled
72867308
type: object
7309+
x-kubernetes-validations:
7310+
- message: extraConfig must not contain keys that duplicate typed
7311+
fields (enabled, tracking_uri, ui_url, tracking_auth, auto_log,
7312+
auto_log_entity_df, entity_df_max_rows, log_operations, ops_experiment_suffix);
7313+
use the corresponding spec fields instead.
7314+
rule: '!has(self.extraConfig) || !(''enabled'' in self.extraConfig)
7315+
&& !(''tracking_uri'' in self.extraConfig) && !(''ui_url''
7316+
in self.extraConfig) && !(''tracking_auth'' in self.extraConfig)
7317+
&& !(''auto_log'' in self.extraConfig) && !(''auto_log_entity_df''
7318+
in self.extraConfig) && !(''entity_df_max_rows'' in self.extraConfig)
7319+
&& !(''log_operations'' in self.extraConfig) && !(''ops_experiment_suffix''
7320+
in self.extraConfig)'
72877321
openlineage:
72887322
description: |-
72897323
OpenLineage enables OpenLineage data lineage tracking for Feast operations.

‎infra/feast-operator/dist/install.yaml‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -906,6 +906,11 @@ spec:
906906
Suffix appended to the project name for the operations experiment.
907907
Defaults to "-feast-ops".
908908
type: string
909+
trackingAuth:
910+
description: |-
911+
Authentication method used by Feast pods when calling the MLflow tracking
912+
server.
913+
type: string
909914
trackingUri:
910915
description: |-
911916
MLflow tracking server URI. When omitted, the operator auto-discovers
@@ -918,6 +923,18 @@ spec:
918923
required:
919924
- enabled
920925
type: object
926+
x-kubernetes-validations:
927+
- message: extraConfig must not contain keys that duplicate typed
928+
fields (enabled, tracking_uri, ui_url, tracking_auth, auto_log,
929+
auto_log_entity_df, entity_df_max_rows, log_operations, ops_experiment_suffix);
930+
use the corresponding spec fields instead.
931+
rule: '!has(self.extraConfig) || !(''enabled'' in self.extraConfig)
932+
&& !(''tracking_uri'' in self.extraConfig) && !(''ui_url'' in
933+
self.extraConfig) && !(''tracking_auth'' in self.extraConfig)
934+
&& !(''auto_log'' in self.extraConfig) && !(''auto_log_entity_df''
935+
in self.extraConfig) && !(''entity_df_max_rows'' in self.extraConfig)
936+
&& !(''log_operations'' in self.extraConfig) && !(''ops_experiment_suffix''
937+
in self.extraConfig)'
921938
openlineage:
922939
description: |-
923940
OpenLineage enables OpenLineage data lineage tracking for Feast operations.
@@ -7280,6 +7297,11 @@ spec:
72807297
Suffix appended to the project name for the operations experiment.
72817298
Defaults to "-feast-ops".
72827299
type: string
7300+
trackingAuth:
7301+
description: |-
7302+
Authentication method used by Feast pods when calling the MLflow tracking
7303+
server.
7304+
type: string
72837305
trackingUri:
72847306
description: |-
72857307
MLflow tracking server URI. When omitted, the operator auto-discovers
@@ -7292,6 +7314,18 @@ spec:
72927314
required:
72937315
- enabled
72947316
type: object
7317+
x-kubernetes-validations:
7318+
- message: extraConfig must not contain keys that duplicate typed
7319+
fields (enabled, tracking_uri, ui_url, tracking_auth, auto_log,
7320+
auto_log_entity_df, entity_df_max_rows, log_operations, ops_experiment_suffix);
7321+
use the corresponding spec fields instead.
7322+
rule: '!has(self.extraConfig) || !(''enabled'' in self.extraConfig)
7323+
&& !(''tracking_uri'' in self.extraConfig) && !(''ui_url''
7324+
in self.extraConfig) && !(''tracking_auth'' in self.extraConfig)
7325+
&& !(''auto_log'' in self.extraConfig) && !(''auto_log_entity_df''
7326+
in self.extraConfig) && !(''entity_df_max_rows'' in self.extraConfig)
7327+
&& !(''log_operations'' in self.extraConfig) && !(''ops_experiment_suffix''
7328+
in self.extraConfig)'
72957329
openlineage:
72967330
description: |-
72977331
OpenLineage enables OpenLineage data lineage tracking for Feast operations.

‎infra/feast-operator/docs/api/markdown/ref.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -581,6 +581,10 @@ DataFrames exceeding this limit are skipped. Defaults to 100000. |
581581
Defaults to false. |
582582
| `opsExperimentSuffix` _string_ | Suffix appended to the project name for the operations experiment.
583583
Defaults to "-feast-ops". |
584+
| `trackingAuth` _string_ | Authentication method used by Feast pods when calling the MLflow tracking
585+
server. Common values: "kubernetes-namespaced" (token-based, default on
586+
OpenShift AI), "basic", "bearer", or "" (no auth for local/dev).
587+
Defaults to "kubernetes-namespaced". |
584588
| `extraConfig` _object (keys:string, values:string)_ | ExtraConfig holds additional MLflow key-value settings written inline into
585589
the mlflow block of feature_store.yaml. Boolean and integer string values
586590
are coerced to native YAML types. Keys must be valid Feast MlflowConfig

0 commit comments

Comments
 (0)