Visitar URL original
refactor: Remove UIVersion context and related components to simplify… · feast-dev/feast@8d3abd8 · GitHub
Skip to content

Commit 8d3abd8

Browse files
committed
refactor: Remove UIVersion context and related components to simplify UI structure
Signed-off-by: Rohit Bharmal <rohitbharmal123@gmail.com>
1 parent a3e38db commit 8d3abd8

10 files changed

Lines changed: 63 additions & 184 deletions

File tree

‎ui/src/FeastUISansProviders.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import "./index.css";
55
import { Routes, Route } from "react-router-dom";
66
import { EuiProvider, EuiErrorBoundary } from "@elastic/eui";
77
import { ThemeProvider, useTheme } from "./contexts/ThemeContext";
8-
import { UIVersionProvider } from "./contexts/UIVersionContext";
98

109
import ProjectOverviewPage from "./pages/ProjectOverviewPage";
1110
import Layout from "./pages/Layout";
@@ -79,13 +78,11 @@ const FeastUISansProviders = ({
7978

8079
return (
8180
<ThemeProvider>
82-
<UIVersionProvider>
83-
<FeastUISansProvidersInner
84-
basename={basename}
85-
projectListContext={projectListContext}
86-
feastUIConfigs={feastUIConfigs}
87-
/>
88-
</UIVersionProvider>
81+
<FeastUISansProvidersInner
82+
basename={basename}
83+
projectListContext={projectListContext}
84+
feastUIConfigs={feastUIConfigs}
85+
/>
8986
</ThemeProvider>
9087
);
9188
};

‎ui/src/components/UIVersionToggle.tsx‎

Lines changed: 0 additions & 25 deletions
This file was deleted.

‎ui/src/contexts/UIVersionContext.tsx‎

Lines changed: 0 additions & 51 deletions
This file was deleted.

‎ui/src/pages/Layout.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import RegistrySearch, {
2626
} from "../components/RegistrySearch";
2727
import GlobalSearchShortcut from "../components/GlobalSearchShortcut";
2828
import CommandPalette from "../components/CommandPalette";
29-
import UIVersionToggle from "../components/UIVersionToggle";
3029

3130
const Layout = () => {
3231
// Registry Path Context has to be inside Layout
@@ -257,9 +256,7 @@ const Layout = () => {
257256
categories={globalCategories}
258257
/>
259258
</EuiFlexItem>
260-
<EuiFlexItem grow={false}>
261-
<UIVersionToggle />
262-
</EuiFlexItem>
259+
<EuiFlexItem grow={false}></EuiFlexItem>
263260
</EuiFlexGroup>
264261
</div>
265262
)}

‎ui/src/pages/data-sources/DataSourceOverviewTab.tsx‎

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import BatchSourcePropertiesView from "./BatchSourcePropertiesView";
2626
import FeatureViewEdgesList from "../entities/FeatureViewEdgesList";
2727
import RequestDataSourceSchemaTable from "./RequestDataSourceSchemaTable";
2828
import useLoadDataSource from "./useLoadDataSource";
29-
import { useUIVersion } from "../../contexts/UIVersionContext";
3029

3130
const buildEditFormData = (ds: any): DataSourceFormData => {
3231
const spec = ds.spec || ds;
@@ -130,7 +129,6 @@ const DataSourceOverviewTab = () => {
130129
useLoadDataSource(dsName);
131130
const isEmpty = data === undefined;
132131

133-
const { isV2 } = useUIVersion();
134132
const [isEditModalOpen, setIsEditModalOpen] = useState(false);
135133
const [successMessage, setSuccessMessage] = useState<string | null>(null);
136134
const [errorMessage, setErrorMessage] = useState<string | null>(null);
@@ -192,21 +190,17 @@ const DataSourceOverviewTab = () => {
192190
<EuiSpacer size="m" />
193191
</>
194192
)}
195-
{isV2 && (
196-
<>
197-
<EuiFlexGroup justifyContent="flexEnd">
198-
<EuiFlexItem grow={false}>
199-
<EuiButtonEmpty
200-
iconType="pencil"
201-
onClick={() => setIsEditModalOpen(true)}
202-
>
203-
Edit Data Source
204-
</EuiButtonEmpty>
205-
</EuiFlexItem>
206-
</EuiFlexGroup>
207-
<EuiSpacer size="s" />
208-
</>
209-
)}
193+
<EuiFlexGroup justifyContent="flexEnd">
194+
<EuiFlexItem grow={false}>
195+
<EuiButtonEmpty
196+
iconType="pencil"
197+
onClick={() => setIsEditModalOpen(true)}
198+
>
199+
Edit Data Source
200+
</EuiButtonEmpty>
201+
</EuiFlexItem>
202+
</EuiFlexGroup>
203+
<EuiSpacer size="s" />
210204
<EuiFlexGroup>
211205
<EuiFlexItem>
212206
<EuiFlexGroup>

‎ui/src/pages/data-sources/Index.tsx‎

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import DataSourceFormModal, {
2424
DataSourceFormData,
2525
} from "../../components/DataSourceFormModal";
2626
import { useApplyDataSource } from "../../queries/mutations/useDataSourceMutations";
27-
import { useUIVersion } from "../../contexts/UIVersionContext";
2827
import useResourceQuery, {
2928
dataSourceListPath,
3029
} from "../../queries/useResourceQuery";
@@ -105,8 +104,6 @@ const formDataToPayload = (formData: DataSourceFormData, project: string) => {
105104

106105
const Index = () => {
107106
const { projectName } = useParams();
108-
const { isV2 } = useUIVersion();
109-
110107
const { isLoading, isSuccess, isError, data } = useLoadDatasources();
111108

112109
const [isModalOpen, setIsModalOpen] = useState(false);
@@ -147,18 +144,14 @@ const Index = () => {
147144
iconType={DataSourceIcon}
148145
pageTitle="Data Sources"
149146
rightSideItems={[
150-
...(isV2
151-
? [
152-
<EuiButton
153-
fill
154-
iconType="plus"
155-
onClick={() => setIsModalOpen(true)}
156-
key="create"
157-
>
158-
Create Data Source
159-
</EuiButton>,
160-
]
161-
: []),
147+
<EuiButton
148+
fill
149+
iconType="plus"
150+
onClick={() => setIsModalOpen(true)}
151+
key="create"
152+
>
153+
Create Data Source
154+
</EuiButton>,
162155
<ExportButton
163156
data={filterResult ?? []}
164157
fileName="data_sources"

‎ui/src/pages/entities/EntityOverviewTab.tsx‎

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ import { toDate } from "../../utils/timestamp";
3131
import FeatureViewEdgesList from "./FeatureViewEdgesList";
3232
import useFeatureViewEdgesByEntity from "./useFeatureViewEdgesByEntity";
3333
import useLoadEntity from "./useLoadEntity";
34-
import { useUIVersion } from "../../contexts/UIVersionContext";
3534
import { useApplyEntity } from "../../queries/mutations/useEntityMutations";
3635

3736
const buildEditFormData = (entity: feast.core.IEntity): EntityFormData => {
@@ -63,7 +62,6 @@ const EntityOverviewTab = () => {
6362
const fvEdgesSuccess = fvEdges.isSuccess;
6463
const fvEdgesData = fvEdges.data;
6564

66-
const { isV2 } = useUIVersion();
6765
const [isEditModalOpen, setIsEditModalOpen] = useState(false);
6866
const [successMessage, setSuccessMessage] = useState<string | null>(null);
6967
const [errorMessage, setErrorMessage] = useState<string | null>(null);
@@ -130,21 +128,17 @@ const EntityOverviewTab = () => {
130128
<EuiSpacer size="m" />
131129
</>
132130
)}
133-
{isV2 && (
134-
<>
135-
<EuiFlexGroup justifyContent="flexEnd">
136-
<EuiFlexItem grow={false}>
137-
<EuiButtonEmpty
138-
iconType="pencil"
139-
onClick={() => setIsEditModalOpen(true)}
140-
>
141-
Edit Entity
142-
</EuiButtonEmpty>
143-
</EuiFlexItem>
144-
</EuiFlexGroup>
145-
<EuiSpacer size="s" />
146-
</>
147-
)}
131+
<EuiFlexGroup justifyContent="flexEnd">
132+
<EuiFlexItem grow={false}>
133+
<EuiButtonEmpty
134+
iconType="pencil"
135+
onClick={() => setIsEditModalOpen(true)}
136+
>
137+
Edit Entity
138+
</EuiButtonEmpty>
139+
</EuiFlexItem>
140+
</EuiFlexGroup>
141+
<EuiSpacer size="s" />
148142
<EuiFlexGroup>
149143
<EuiFlexItem>
150144
<EuiPanel hasBorder={true}>

‎ui/src/pages/entities/Index.tsx‎

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import EntityFormModal, {
1919
EntityFormData,
2020
} from "../../components/EntityFormModal";
2121
import { useApplyEntity } from "../../queries/mutations/useEntityMutations";
22-
import { useUIVersion } from "../../contexts/UIVersionContext";
2322
import useResourceQuery, {
2423
entityListPath,
2524
} from "../../queries/useResourceQuery";
@@ -48,8 +47,6 @@ const formDataToPayload = (formData: EntityFormData, project: string) => ({
4847

4948
const Index = () => {
5049
const { projectName } = useParams();
51-
const { isV2 } = useUIVersion();
52-
5350
const { isLoading, isSuccess, isError, data } = useLoadEntities();
5451

5552
const [isModalOpen, setIsModalOpen] = useState(false);
@@ -84,18 +81,14 @@ const Index = () => {
8481
iconType={EntityIcon}
8582
pageTitle="Entities"
8683
rightSideItems={[
87-
...(isV2
88-
? [
89-
<EuiButton
90-
fill
91-
iconType="plus"
92-
onClick={() => setIsModalOpen(true)}
93-
key="create"
94-
>
95-
Create Entity
96-
</EuiButton>,
97-
]
98-
: []),
84+
<EuiButton
85+
fill
86+
iconType="plus"
87+
onClick={() => setIsModalOpen(true)}
88+
key="create"
89+
>
90+
Create Entity
91+
</EuiButton>,
9992
<ExportButton
10093
data={data ?? []}
10194
fileName="entities"

‎ui/src/pages/feature-views/Index.tsx‎

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ import FeatureViewFormModal, {
3535
FeatureViewFormData,
3636
} from "../../components/FeatureViewFormModal";
3737
import { useApplyFeatureView } from "../../queries/mutations/useFeatureViewMutations";
38-
import { useUIVersion } from "../../contexts/UIVersionContext";
3938
import useResourceQuery, {
4039
featureViewListPath,
4140
restFeatureViewsToMergedList,
@@ -125,8 +124,6 @@ const formDataToPayload = (formData: FeatureViewFormData, project: string) => ({
125124

126125
const Index = () => {
127126
const { projectName } = useParams();
128-
const { isV2 } = useUIVersion();
129-
130127
const { isLoading, isSuccess, isError, data } = useLoadFeatureViews();
131128

132129
const entitiesQuery = useResourceQuery<any[]>({
@@ -213,18 +210,14 @@ const Index = () => {
213210
iconType={FeatureViewIcon}
214211
pageTitle="Feature Views"
215212
rightSideItems={[
216-
...(isV2
217-
? [
218-
<EuiButton
219-
fill
220-
iconType="plus"
221-
onClick={handleCreateClick}
222-
key="create"
223-
>
224-
Create Feature View
225-
</EuiButton>,
226-
]
227-
: []),
213+
<EuiButton
214+
fill
215+
iconType="plus"
216+
onClick={handleCreateClick}
217+
key="create"
218+
>
219+
Create Feature View
220+
</EuiButton>,
228221
<ExportButton
229222
data={filterResult ?? []}
230223
fileName="feature_views"

0 commit comments

Comments
 (0)