Visitar URL original
fix: Keep tiling, offline and stream engine settings when copying a S… · feast-dev/feast@9625bb4 · GitHub
Skip to content

Commit 9625bb4

Browse files
Rodrigo-Palmajyejare
authored andcommitted
fix: Keep tiling, offline and stream engine settings when copying a StreamFeatureView
Signed-off-by: Rodrigo-Palma <email.rodrigopalma@gmail.com>
1 parent 66ff990 commit 9625bb4

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

‎sdk/python/feast/stream_feature_view.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -462,6 +462,7 @@ def __copy__(self):
462462
ttl=self.ttl,
463463
tags=self.tags,
464464
online=self.online,
465+
offline=self.offline,
465466
description=self.description,
466467
owner=self.owner,
467468
org=self.org,
@@ -472,6 +473,9 @@ def __copy__(self):
472473
udf=self.udf,
473474
udf_string=self.udf_string,
474475
feature_transformation=self.feature_transformation,
476+
stream_engine=self.stream_engine,
477+
enable_tiling=self.enable_tiling,
478+
tiling_hop_size=self.tiling_hop_size,
475479
enable_validation=self.enable_validation,
476480
version=self.version,
477481
)

‎sdk/python/tests/unit/test_stream_feature_view.py‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,8 +222,17 @@ def test_stream_feature_view_copy():
222222
source=stream_source,
223223
aggregations=[],
224224
udf=lambda x: x,
225+
offline=True,
226+
enable_tiling=True,
227+
tiling_hop_size=timedelta(minutes=1),
228+
stream_engine={"spark.sql.shuffle.partitions": "4"},
225229
)
226-
assert sfv == copy.copy(sfv)
230+
sfv_copy = copy.copy(sfv)
231+
assert sfv == sfv_copy
232+
assert sfv_copy.offline
233+
assert sfv_copy.enable_tiling
234+
assert sfv_copy.tiling_hop_size == timedelta(minutes=1)
235+
assert sfv_copy.stream_engine == {"spark.sql.shuffle.partitions": "4"}
227236

228237

229238
def test_update_materialization_intervals():

0 commit comments

Comments
 (0)