|
| 1 | +/* |
| 2 | +Copyright 2026 Feast Community. |
| 3 | +
|
| 4 | +Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | +you may not use this file except in compliance with the License. |
| 6 | +You may obtain a copy of the License at |
| 7 | +
|
| 8 | + http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | +
|
| 10 | +Unless required by applicable law or agreed to in writing, software |
| 11 | +distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | +See the License for the specific language governing permissions and |
| 14 | +limitations under the License. |
| 15 | +*/ |
| 16 | + |
| 17 | +package services |
| 18 | + |
| 19 | +import ( |
| 20 | + "context" |
| 21 | + |
| 22 | + feastdevv1 "github.com/feast-dev/feast/infra/feast-operator/api/v1" |
| 23 | + "github.com/feast-dev/feast/infra/feast-operator/internal/controller/handler" |
| 24 | + . "github.com/onsi/ginkgo/v2" |
| 25 | + . "github.com/onsi/gomega" |
| 26 | + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
| 27 | + "k8s.io/apimachinery/pkg/types" |
| 28 | + "k8s.io/utils/ptr" |
| 29 | +) |
| 30 | + |
| 31 | +var _ = Describe("ServiceMonitor", func() { |
| 32 | + var ( |
| 33 | + featureStore *feastdevv1.FeatureStore |
| 34 | + feast *FeastServices |
| 35 | + typeNamespacedName types.NamespacedName |
| 36 | + ctx context.Context |
| 37 | + ) |
| 38 | + |
| 39 | + BeforeEach(func() { |
| 40 | + ctx = context.Background() |
| 41 | + typeNamespacedName = types.NamespacedName{ |
| 42 | + Name: "sm-test-fs", |
| 43 | + Namespace: "default", |
| 44 | + } |
| 45 | + |
| 46 | + featureStore = &feastdevv1.FeatureStore{ |
| 47 | + ObjectMeta: metav1.ObjectMeta{ |
| 48 | + Name: typeNamespacedName.Name, |
| 49 | + Namespace: typeNamespacedName.Namespace, |
| 50 | + }, |
| 51 | + Spec: feastdevv1.FeatureStoreSpec{ |
| 52 | + FeastProject: "smtestproject", |
| 53 | + Services: &feastdevv1.FeatureStoreServices{ |
| 54 | + OnlineStore: &feastdevv1.OnlineStore{ |
| 55 | + Server: &feastdevv1.ServerConfigs{ |
| 56 | + ContainerConfigs: feastdevv1.ContainerConfigs{ |
| 57 | + DefaultCtrConfigs: feastdevv1.DefaultCtrConfigs{ |
| 58 | + Image: ptr.To("test-image"), |
| 59 | + }, |
| 60 | + }, |
| 61 | + }, |
| 62 | + }, |
| 63 | + Registry: &feastdevv1.Registry{ |
| 64 | + Local: &feastdevv1.LocalRegistryConfig{ |
| 65 | + Server: &feastdevv1.RegistryServerConfigs{ |
| 66 | + ServerConfigs: feastdevv1.ServerConfigs{ |
| 67 | + ContainerConfigs: feastdevv1.ContainerConfigs{ |
| 68 | + DefaultCtrConfigs: feastdevv1.DefaultCtrConfigs{ |
| 69 | + Image: ptr.To("test-image"), |
| 70 | + }, |
| 71 | + }, |
| 72 | + }, |
| 73 | + GRPC: ptr.To(true), |
| 74 | + }, |
| 75 | + }, |
| 76 | + }, |
| 77 | + }, |
| 78 | + }, |
| 79 | + } |
| 80 | + |
| 81 | + Expect(k8sClient.Create(ctx, featureStore)).To(Succeed()) |
| 82 | + |
| 83 | + feast = &FeastServices{ |
| 84 | + Handler: handler.FeastHandler{ |
| 85 | + Client: k8sClient, |
| 86 | + Context: ctx, |
| 87 | + Scheme: k8sClient.Scheme(), |
| 88 | + FeatureStore: featureStore, |
| 89 | + }, |
| 90 | + } |
| 91 | + |
| 92 | + Expect(feast.ApplyDefaults()).To(Succeed()) |
| 93 | + applySpecToStatus(featureStore) |
| 94 | + feast.refreshFeatureStore(ctx, typeNamespacedName) |
| 95 | + }) |
| 96 | + |
| 97 | + AfterEach(func() { |
| 98 | + testSetHasServiceMonitorCRD(false) |
| 99 | + Expect(k8sClient.Delete(ctx, featureStore)).To(Succeed()) |
| 100 | + }) |
| 101 | + |
| 102 | + Describe("initServiceMonitor", func() { |
| 103 | + It("should create an unstructured ServiceMonitor with correct GVK and name", func() { |
| 104 | + sm := feast.initServiceMonitor() |
| 105 | + Expect(sm).NotTo(BeNil()) |
| 106 | + Expect(sm.GetKind()).To(Equal("ServiceMonitor")) |
| 107 | + Expect(sm.GetAPIVersion()).To(Equal("monitoring.coreos.com/v1")) |
| 108 | + Expect(sm.GetName()).To(Equal(feast.GetFeastServiceName(OnlineFeastType))) |
| 109 | + Expect(sm.GetNamespace()).To(Equal(featureStore.Namespace)) |
| 110 | + }) |
| 111 | + }) |
| 112 | + |
| 113 | + Describe("setServiceMonitor", func() { |
| 114 | + It("should populate the ServiceMonitor spec with correct selector and endpoint", func() { |
| 115 | + sm := feast.initServiceMonitor() |
| 116 | + Expect(feast.setServiceMonitor(sm)).To(Succeed()) |
| 117 | + |
| 118 | + labels := sm.GetLabels() |
| 119 | + Expect(labels).To(HaveKeyWithValue(NameLabelKey, featureStore.Name)) |
| 120 | + Expect(labels).To(HaveKeyWithValue(ServiceTypeLabelKey, string(OnlineFeastType))) |
| 121 | + |
| 122 | + spec, ok := sm.Object["spec"].(map[string]interface{}) |
| 123 | + Expect(ok).To(BeTrue()) |
| 124 | + |
| 125 | + endpoints, ok := spec["endpoints"].([]interface{}) |
| 126 | + Expect(ok).To(BeTrue()) |
| 127 | + Expect(endpoints).To(HaveLen(1)) |
| 128 | + ep := endpoints[0].(map[string]interface{}) |
| 129 | + Expect(ep["port"]).To(Equal("metrics")) |
| 130 | + Expect(ep["path"]).To(Equal("/metrics")) |
| 131 | + |
| 132 | + selector, ok := spec["selector"].(map[string]interface{}) |
| 133 | + Expect(ok).To(BeTrue()) |
| 134 | + matchLabels := selector["matchLabels"].(map[string]interface{}) |
| 135 | + Expect(matchLabels[NameLabelKey]).To(Equal(featureStore.Name)) |
| 136 | + Expect(matchLabels[ServiceTypeLabelKey]).To(Equal(string(OnlineFeastType))) |
| 137 | + |
| 138 | + ownerRefs := sm.GetOwnerReferences() |
| 139 | + Expect(ownerRefs).To(HaveLen(1)) |
| 140 | + Expect(ownerRefs[0].Name).To(Equal(featureStore.Name)) |
| 141 | + Expect(*ownerRefs[0].Controller).To(BeTrue()) |
| 142 | + }) |
| 143 | + }) |
| 144 | + |
| 145 | + Describe("createOrDeleteServiceMonitor", func() { |
| 146 | + It("should be a no-op when ServiceMonitor CRD is not available", func() { |
| 147 | + testSetHasServiceMonitorCRD(false) |
| 148 | + Expect(feast.createOrDeleteServiceMonitor()).To(Succeed()) |
| 149 | + }) |
| 150 | + |
| 151 | + It("should not error when metrics is not enabled and CRD is unavailable", func() { |
| 152 | + testSetHasServiceMonitorCRD(false) |
| 153 | + featureStore.Status.Applied.Services.OnlineStore.Server.Metrics = ptr.To(false) |
| 154 | + Expect(feast.createOrDeleteServiceMonitor()).To(Succeed()) |
| 155 | + }) |
| 156 | + }) |
| 157 | + |
| 158 | + Describe("HasServiceMonitorCRD", func() { |
| 159 | + It("should return false by default", func() { |
| 160 | + testSetHasServiceMonitorCRD(false) |
| 161 | + Expect(HasServiceMonitorCRD()).To(BeFalse()) |
| 162 | + }) |
| 163 | + |
| 164 | + It("should return true when set", func() { |
| 165 | + testSetHasServiceMonitorCRD(true) |
| 166 | + Expect(HasServiceMonitorCRD()).To(BeTrue()) |
| 167 | + }) |
| 168 | + }) |
| 169 | +}) |
0 commit comments