Visitar URL original
Add ".with_name" method to FeatureView (Part of shadow entities mapping changes) · Issue #1867 · feast-dev/feast · GitHub
Skip to content

Add ".with_name" method to FeatureView (Part of shadow entities mapping changes) #1867

Description

@mavysavydav

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
As part of the shadow entities mapping agreed design, we'll need this method. This method will prevent name collisions when the same FeatureView is joined more than once onto to the entity data. Here's the RFC - https://docs.google.com/document/d/1TsCwKf3nVXTAfL0f8i26jnCgHA3bRd4dKQ8QdM87vIA/edit#

Describe the solution you'd like
A clear and concise description of what you want to happen.
Add a ".with_name" method to FeatureView class that'll return a copy of the FeatureView with the passed name instead.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

We considered having a name be automatically produced in the shadow entities that has the shadow entity join_keys included in the name. The issue with this is that the name may become too long in the case of composite entities. We also considered just having a numerical counter in the name like fv_name_0_feature_name, fv_name_1_feature_name.

Additional context
Add any other context or screenshots about the feature request here.

Activity

  1. self-assigned this
    on Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions