Visitar URL original
No error check when missing entity · Issue #123 · feathersjs/feathers-permissions · GitHub
Skip to content

No error check when missing entity #123

Open

Description

@ericuldall

If doing a permissions check on a route that may be accessed by a logged out user there is no check for the error flag.
https://github.com/feathersjs-ecosystem/feathers-permissions/blob/release/lib/index.js#L33

This causes an issue because currently I'm using permissions check in users before hooks with error false. This makes it easier than implementing it on every method except POST (which you would obviously be logged out for in the event of a new registration).

Is there some reason the error check is not implemented there?

Activity

  1. ericuldall commented on Feb 8, 2022

    @ericuldall
    Author

    Sent a PR if there's no objection to it.

  2. ericuldall commented on Feb 8, 2022

    @ericuldall
    Author

    Just realized this issue was closed as stale before but I think the OP had a valid point and happy to further the discussion.
    #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions