Processing POST request in several Content Types #604

Activity

1. mjl commented on Nov 28, 2015

   

   mjl

   on Nov 28, 2015

   Contributor

   More actions

   The problem is that you are returning something from process(). This will short-circuit the evaluation of further content types and use the HttpResponseRedirect returned as the overall return value of the page. FeinCMS assumes that if a content type returns a HttpResponseSomething, it has a deeper reason for doing that and the rest of the page won't be rendered anyway, so it won't process any further content types.

   That means the easiest way to make both content types work is not to return something from process().

   Perhaps we should process() all CTs anyway? Opinions?
2. paramono commented on Nov 29, 2015

   

   paramono

   on Nov 29, 2015

   ContributorAuthor

   More actions

   The problem is that you are returning something from process(). This will short-circuit the evaluation of further content types and use the HttpResponseRedirect returned as the overall return value of the page. FeinCMS assumes that if a content type returns a HttpResponseSomething

   Not exactly. Yes, you can short-circuit evaluation if you return HttpResponseSomething from your CT, but you can return True, letting other content types to be processed normally. I noticed that this is what occurs in case of GET, and so investigated a bit further why I am getting problems with POST. Look for the link to mixins module below.

   Perhaps we should process() all CTs anyway? Opinions?

   It seems that all content types are actually processed:
   feincms.module.mixins

   I realized that the origin of my issue lied in a completely different place. The thing is, I also put an ApplicationContent above both of these forms. 3rd party apps require urlpatterns defined, and the docs use class-based view (ListView) in the app urls.

   When 3rd party app is defined this way, it actually tries to accept post requests, but fails to do so - the code in mixins module raises django.http.response.HttpResponseNotAllowed, preventing other content types from processing POST request (since http responses short circuit the execution, as you mentioned)

   My solution to this particular problem was simple - I made a child class of ListView with an empty post() method, like so:

   class CustomizedListView(ListView):
       # ... your code here
       def post(self, request, **kwargs):
           return True
   

   This prevents ApplicationContent instances from raising HttpResponseNotAllowed on POST requests: they return True instead, and let your process it in the other content types present on your page.

   ---

   Now, back to the forms: yes, you can easily solve this problem if you assign a unique name attribute for submit buttons per each type of your CT Form:

   <button type="submit" name="ct_form_type" value="Submit" id="form_id" class="btn btn-success">
   Submit
   </button>
   

   Then the process() method of each content type form should be implemented like so:

   def process(self, request, **kwargs):
       if request.method == 'POST':
           if not 'ct_form_type' in request.POST: return True
           # ...
   

   In other words, we check that we stumbled across the right handler before processing the form itself. If this is the wrong handler, we return True, giving other content types a chance to process POST. If neither of content types handles POST, 405 status code is returned.
3. matthiask

   added

   documentation

   on Oct 17, 2017