Visitar URL original
feat(sql_connect): merge "X-Client-Platform" header into "X-Client-Ve… · firebase/flutterfire@049fe5e · GitHub
Skip to content

Commit 049fe5e

Browse files
authored
feat(sql_connect): merge "X-Client-Platform" header into "X-Client-Version" (#18502)
1 parent e512d39 commit 049fe5e

3 files changed

Lines changed: 3 additions & 40 deletions

File tree

‎packages/firebase_data_connect/firebase_data_connect/lib/src/network/rest_transport.dart‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@ class RestTransport implements DataConnectTransport {
8686
'Accept': 'application/json',
8787
'x-goog-api-client': getGoogApiVal(sdkType, packageVersion),
8888
'x-firebase-client': getFirebaseClientVal(packageVersion),
89-
'x-client-platform': 'flutter',
90-
'x-client-version': packageVersion,
89+
'x-client-version': 'flutter/$packageVersion',
9190
};
9291
String? appCheckToken;
9392
try {

‎packages/firebase_data_connect/firebase_data_connect/lib/src/network/websocket_transport.dart‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,7 @@ class WebSocketTransport implements DataConnectTransport {
200200
Map<String, String> headers = {
201201
'x-goog-api-client': getGoogApiVal(sdkType, packageVersion),
202202
'x-firebase-client': getFirebaseClientVal(packageVersion),
203-
'x-client-platform': 'flutter',
204-
'x-client-version': packageVersion
203+
'x-client-version': 'flutter/$packageVersion',
205204
};
206205
if (authToken != null) {
207206
headers['X-Firebase-Auth-Token'] = authToken;

‎packages/firebase_data_connect/firebase_data_connect/test/src/network/rest_transport_test.dart‎

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -276,41 +276,6 @@ void main() {
276276
).called(1);
277277
});
278278

279-
test('invokeOperation should include x-client-platform headers', () async {
280-
final mockResponse = http.Response('{"data": {"key": "value"}}', 200);
281-
when(
282-
mockHttpClient.post(
283-
any,
284-
headers: anyNamed('headers'),
285-
body: anyNamed('body'),
286-
),
287-
).thenAnswer((_) async => mockResponse);
288-
289-
String deserializer(String data) => 'Deserialized Data';
290-
291-
await transport.invokeOperation(
292-
'testQuery',
293-
'executeQuery',
294-
deserializer,
295-
null,
296-
null,
297-
'authToken123',
298-
);
299-
300-
verify(
301-
mockHttpClient.post(
302-
any,
303-
headers: argThat(
304-
allOf(
305-
containsPair('x-client-platform', 'flutter'),
306-
),
307-
named: 'headers',
308-
),
309-
body: anyNamed('body'),
310-
),
311-
).called(1);
312-
});
313-
314279
test('invokeOperation should include x-client-version headers', () async {
315280
final mockResponse = http.Response('{"data": {"key": "value"}}', 200);
316281
when(
@@ -337,7 +302,7 @@ void main() {
337302
any,
338303
headers: argThat(
339304
allOf(
340-
containsPair('x-client-version', packageVersion),
305+
containsPair('x-client-version', 'flutter/$packageVersion'),
341306
),
342307
named: 'headers',
343308
),

0 commit comments

Comments
 (0)