Visitar URL original
feat(web): update to `web: ^1.0.0` (#13200) · firebase/flutterfire@8fab04a · GitHub
Skip to content

Commit 8fab04a

Browse files
Lyokonerussellwheatley
Lyokone
and
russellwheatley
authored
feat(web): update to web: ^1.0.0 (#13200)
* feat(web): update to web 1.0.0 * update example apps * update JS Interop * update CI * Update other packages dependencies * fix typing * test: skip app check `activate()` on web * analyse issue * test: revert skip * test: move app check web to seperate test runner * test: update app check test runner * test: use macos runner * chore: remove code comment * test: update e2e tests for web * update * update * test: fix app-check test runner * chore: improve logic * revert logic * test: update test running implementation * test: use debug token for app check --------- Co-authored-by: russellwheatley <russellwheatley85@gmail.com>
1 parent 6969e48 commit 8fab04a

28 files changed

Lines changed: 60 additions & 62 deletions

File tree

‎.github/workflows/e2e_tests.yaml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,8 +359,7 @@ jobs:
359359
java-version: '17'
360360
- uses: subosito/flutter-action@44ac965b96f18d999802d4b807e3256d5a3f9fa1
361361
with:
362-
# TODO: Remove this once WASM is on stable.
363-
channel: 'master'
362+
channel: 'stable'
364363
cache: true
365364
- uses: bluefireteam/melos-action@7e70fbe34bbd91a75eb505eeb4174b0ac9a1df52
366365
with:

‎packages/cloud_firestore/cloud_firestore_web/pubspec.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ repository: https://github.com/firebase/flutterfire/tree/main/packages/cloud_fir
66
version: 4.2.0
77

88
environment:
9-
sdk: '>=3.2.0 <4.0.0'
10-
flutter: '>=3.3.0'
9+
sdk: '>=3.4.0 <4.0.0'
10+
flutter: '>=3.22.0'
1111

1212
dependencies:
1313
_flutterfire_internals: ^1.3.41

‎packages/cloud_functions/cloud_functions_web/pubspec.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ repository: https://github.com/firebase/flutterfire/tree/main/packages/cloud_fun
66
version: 4.9.12
77

88
environment:
9-
sdk: '>=3.2.0 <4.0.0'
10-
flutter: '>=3.3.0'
9+
sdk: '>=3.4.0 <4.0.0'
10+
flutter: '>=3.22.0'
1111

1212
dependencies:
1313
cloud_functions_platform_interface: ^5.5.34

‎packages/firebase_analytics/firebase_analytics_web/lib/interop/analytics.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class Analytics extends JsObjectWrapper<analytics_interop.AnalyticsJsImpl> {
4040

4141
static Future<bool> isSupported() async {
4242
final result = await analytics_interop.isSupported().toDart;
43-
return (result! as JSBoolean).toDart;
43+
return result.toDart;
4444
}
4545

4646
/// Non-null App for this instance of analytics service.

‎packages/firebase_analytics/firebase_analytics_web/lib/interop/analytics_interop.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ external AnalyticsJsImpl initializeAnalytics(
2424

2525
@JS()
2626
@staticInterop
27-
external JSPromise /* bool */ isSupported();
27+
external JSPromise<JSBoolean> isSupported();
2828

2929
@JS()
3030
@staticInterop

‎packages/firebase_analytics/firebase_analytics_web/pubspec.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ repository: https://github.com/firebase/flutterfire/tree/main/packages/firebase_
55
version: 0.5.9+2
66

77
environment:
8-
sdk: '>=3.2.0 <4.0.0'
9-
flutter: '>=3.3.0'
8+
sdk: '>=3.4.0 <4.0.0'
9+
flutter: '>=3.22.0'
1010

1111
dependencies:
1212
_flutterfire_internals: ^1.3.41

‎packages/firebase_app_check/firebase_app_check_web/pubspec.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ homepage: https://github.com/firebase/flutterfire/tree/main/packages/firebase_ap
44
version: 0.1.2+13
55

66
environment:
7-
sdk: '>=3.2.0 <4.0.0'
8-
flutter: '>=3.3.0'
7+
sdk: '>=3.4.0 <4.0.0'
8+
flutter: '>=3.22.0'
99

1010
dependencies:
1111
_flutterfire_internals: ^1.3.41
@@ -16,7 +16,7 @@ dependencies:
1616
sdk: flutter
1717
flutter_web_plugins:
1818
sdk: flutter
19-
web: ^0.5.1
19+
web: ^1.0.0
2020

2121
dev_dependencies:
2222
build_runner: ^2.3.3

‎packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@ class Installations
3434

3535
Future<String> getId() => (installations_interop.getId(jsObject))
3636
.toDart
37-
.then((value) => value! as String);
37+
.then((value) => value as String);
3838

3939
Future<String> getToken([bool forceRefresh = false]) =>
4040
(installations_interop.getToken(jsObject, forceRefresh.toJS))
4141
.toDart
42-
.then((value) => value! as String);
42+
.then((value) => value as String);
4343

4444
JSFunction? _onIdChangedUnsubscribe;
4545

‎packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations_interop.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ external InstallationsJsImpl getInstallations([AppJsImpl? app]);
1515

1616
@JS()
1717
@staticInterop
18-
external JSPromise /* String */ getId(InstallationsJsImpl installations);
18+
external JSPromise<JSString> getId(InstallationsJsImpl installations);
1919

2020
@JS()
2121
@staticInterop
22-
external JSPromise /* String */ getToken(InstallationsJsImpl installations,
22+
external JSPromise<JSString> getToken(InstallationsJsImpl installations,
2323
[JSBoolean? forceRefresh]);
2424

2525
@JS()

‎packages/firebase_app_installations/firebase_app_installations_web/pubspec.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ homepage: https://github.com/firebase/flutterfire/tree/main/packages/firebase_ap
55
repository: https://github.com/firebase/flutterfire/tree/main/packages/firebase_app_installations/firebase_app_installations_web
66

77
environment:
8-
sdk: '>=3.2.0 <4.0.0'
9-
flutter: '>=3.3.0'
8+
sdk: '>=3.4.0 <4.0.0'
9+
flutter: '>=3.22.0'
1010

1111
dependencies:
1212
_flutterfire_internals: ^1.3.41

0 commit comments

Comments
 (0)