Visitar URL original
feat(firebaseai): Added support for Server Prompt Template by cynthiajoan 路 Pull Request #17767 路 firebase/flutterfire 路 GitHub
Skip to content

feat(firebaseai): Added support for Server Prompt Template - #17767

Merged
cynthiajoan merged 28 commits into
mainfrom
firebaseai/server_template
Nov 13, 2025
Merged

feat(firebaseai): Added support for Server Prompt Template#17767
cynthiajoan merged 28 commits into
mainfrom
firebaseai/server_template

Conversation

@cynthiajoan

@cynthiajoan cynthiajoan commented Oct 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add support for Server Prompt Templates.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@paulb777 paulb777 mentioned this pull request Oct 14, 2025
Merged
@cynthiajoan

cynthiajoan commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

/gemini review

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 29, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for server-side templates in Firebase AI, including new model classes (TemplateGenerativeModel, TemplateImagenModel), API abstractions for template URIs, and a new example page to demonstrate the feature. The core logic seems well-structured and is accompanied by tests. My review includes a few points: a critical fix to remove a debug print statement, a high-severity bug fix in the new example page where user input was being ignored, and a low-severity suggestion to refactor some redundant code for better maintainability.

Comment thread packages/firebase_ai/firebase_ai/example/lib/pages/server_template_page.dart
Comment thread packages/firebase_ai/firebase_ai/lib/src/client.dart Outdated
Comment thread packages/firebase_ai/firebase_ai/example/lib/pages/server_template_page.dart
@cynthiajoan
cynthiajoan marked this pull request as ready for review November 10, 2025 01:48
paulb777
paulb777 reviewed Nov 10, 2025
View reviewed changes
Comment thread packages/firebase_ai/firebase_ai/lib/src/server_template/template_generative_model.dart Outdated
Comment thread packages/firebase_ai/firebase_ai/lib/src/server_template/template_generative_model.dart Outdated
Comment thread packages/firebase_ai/firebase_ai/lib/src/server_template/template_imagen_model.dart Outdated
@cynthiajoan cynthiajoan changed the title feat(firebaseai): server template feat(firebaseai): Added support for Server Prompt Template Nov 11, 2025
paulb777
paulb777 approved these changes Nov 11, 2025
View reviewed changes
Comment thread packages/firebase_ai/firebase_ai/lib/src/server_template/template_generative_model.dart
Comment thread packages/firebase_ai/firebase_ai/lib/src/server_template/template_imagen_model.dart
Lyokone
Lyokone approved these changes Nov 13, 2025
View reviewed changes

@Lyokone Lyokone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 馃憤

@cynthiajoan
cynthiajoan merged commit 8ff653e into main Nov 13, 2025
29 of 32 checks passed
@cynthiajoan
cynthiajoan deleted the firebaseai/server_template branch November 13, 2025 17:44
@firebase firebase locked and limited conversation to collaborators Dec 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes
@Lyokone Lyokone Lyokone approved these changes
@russellwheatley russellwheatley Awaiting requested review from russellwheatley
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cynthiajoan @paulb777 @Lyokone