Visitar URL original
refactor(tests): update listener completion logic and improve WebSocket channel handling by SelaseKay · Pull Request #18524 · firebase/flutterfire · GitHub
Skip to content

refactor(tests): update listener completion logic and improve WebSocket channel handling - #18524

Merged
SelaseKay merged 6 commits into
mainfrom
fix/fdc-subscription-cancellation
Aug 4, 2026
Merged

refactor(tests): update listener completion logic and improve WebSocket channel handling#18524
SelaseKay merged 6 commits into
mainfrom
fix/fdc-subscription-cancellation

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes Firebase Data Connect subscription E2E failures by:

  • Synchronizing cancellation tests on query results instead of timing-sensitive event counts.
  • Preventing callbacks from closed WebSocket channels from affecting replacement connections.
  • Safely handling reconnects after the final subscription is cancelled.

Related Issues

Fixes failing fdc e2e tests

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist

gemini-code-assist Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
SelaseKay force-pushed the fix/fdc-subscription-cancellation branch from 194920d to 147c20a Compare August 4, 2026 09:20
@SelaseKay
fix(fdc): stabilize WebSocket reconnect after multiplexed teardown
4e8216e 
Prevent mid-handshake subscribe races, fail superseded connects so callers retry, reset query stream state on cancel, and give native sockets time to settle between e2e tests.
@SelaseKay
SelaseKay force-pushed the fix/fdc-subscription-cancellation branch from 147c20a to 4e8216e Compare August 4, 2026 09:21
@SelaseKay
fix(fdc): keep listen e2e content assertions only
0d23457 
Revert WebSocket transport lifecycle changes that regressed Android/iOS FDC e2e reconnects after multiplexed teardown. Keep the listen cancellation test synchronized on query payloads instead of brittle event counts.
@SelaseKay
SelaseKay force-pushed the fix/fdc-subscription-cancellation branch from d29645c to 0d23457 Compare August 4, 2026 09:49
@SelaseKay
SelaseKay merged commit 6b1fbc9 into main Aug 4, 2026
38 of 41 checks passed
@SelaseKay
SelaseKay deleted the fix/fdc-subscription-cancellation branch August 4, 2026 11:41
@firebase firebase locked and limited conversation to collaborators Sep 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Lyokone Lyokone Lyokone approved these changes
@demolaf demolaf demolaf approved these changes
@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SelaseKay @Lyokone @demolaf