Visitar URL original
refactor(core,android): migrate native implementation to Kotlin by SelaseKay 路 Pull Request #18570 路 firebase/flutterfire 路 GitHub
Skip to content

refactor(core,android): migrate native implementation to Kotlin - #18570

Merged
SelaseKay merged 4 commits into
mainfrom
feat/core-pigeon-kotlin
Aug 19, 2026
Merged

refactor(core,android): migrate native implementation to Kotlin#18570
SelaseKay merged 4 commits into
mainfrom
feat/core-pigeon-kotlin

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Migrates firebase_core on Android from the Pigeon Java generator (javaOut) to Kotlin (kotlinOut), matching recent plugin migrations such as Crashlytics and App Installations.

The HostApi implementation is now Kotlin (FlutterFirebaseCorePlugin). Shared Java types (FlutterFirebasePlugin / FlutterFirebasePluginRegistry) stay Java. Custom auth domains move onto FlutterFirebasePlugin.customAuthDomain (keyed by Dart app name) so firebase_auth no longer reads FlutterFirebaseCorePlugin.customAuthDomain.

This PR is stacked on #18569 (Swift). pigeons/messages.dart is shared, so the two migrations cannot land independently against main without a conflict. After the Swift PR merges, retarget this PR to main.

The InAppMessaging Looper.prepare() workaround from the previous Java plugin is preserved.

Native Android builds and melos run analyze were not run in this change.

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@SelaseKay
refactor(core,apple): migrate iOS/macOS plugin implementation to Swift
dc40fcb 
Switch firebase_core from Pigeon objcOut to swiftOut and implement the
HostApi in Swift. Custom auth domains now live on FLTFirebasePlugin so
firebase_auth does not depend on the Core plugin class.
@SelaseKay
refactor(core,android): migrate native implementation to Kotlin
158892d 
Switch firebase_core from Pigeon javaOut to kotlinOut and implement the
HostApi in Kotlin. Custom auth domains now live on FlutterFirebasePlugin
so firebase_auth does not depend on the Core plugin class.
@gemini-code-assist

gemini-code-assist Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Base automatically changed from feat/core-pigeon-swift to main August 18, 2026 13:56
@SelaseKay
SelaseKay merged commit 7a0f585 into main Aug 19, 2026
127 of 131 checks passed
@SelaseKay
SelaseKay deleted the feat/core-pigeon-kotlin branch August 19, 2026 13:52
@firebase firebase locked and limited conversation to collaborators Sep 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Lyokone Lyokone Lyokone approved these changes
@demolaf demolaf demolaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SelaseKay @Lyokone @demolaf