Visitar URL original
Comparing b7d0e8c9ed70...893650416352 · flutter/flutter · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b7d0e8c9ed70
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 893650416352
Choose a head ref
  • 15 commits
  • 117 files changed
  • 10 contributors

Commits on Sep 18, 2023

  1. Migrate the "Missing frames / speed related performance issues" issue…

    … template to use Github forms (#134033)
    
    Closes #119921
    
    ### Demo
    
    - Demo issue template: [Issue: My app is slow or missing frames](https://github.com/huycozy/flutter/issues/new?assignees=&labels=from%3A+performance+template&projects=&template=5_performance_speed.yml)
    - Demo a filed issue: huycozy#5
    huycozy authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b195c94 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from be7a039 to e1c784e (3 revisions) (#134956)

    flutter-team-archive/engine@be7a039...e1c784e
    
    2023-09-18 skia-flutter-autoroll@skia.org Roll Skia from f8065ca00d0c to 0c990ab9e097 (7 revisions) (flutter-team-archive/engine#45979)
    2023-09-18 mdebbar@google.com [web] ScreenOrientation singleton (flutter-team-archive/engine#45304)
    2023-09-18 mdebbar@google.com [web] De-singletonize MouseCursor for multi-view (flutter-team-archive/engine#45295)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    bac5e5d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9dd3e1e View commit details
    Browse the repository at this point in the history
  4. [flutter roll] Revert "LinkedText (Linkify)" (#134955)

    Reverts #125927
    
    context: b/300804374
    
    Looks like a g3 fix might involve changing the names of widget on the customer app, and I am not sure if that would be the right approach forward. Putting up a revert to be safe for now.
    XilaiZhang authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    6425a3b View commit details
    Browse the repository at this point in the history
  5. Don't uninstall before retrying to connect during app launch (#134542)

    When retrying to connect to the device during app launch, don't uninstall the app first.
    
    Latest test flake for #120808:
    https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8770202475999850785/+/u/run_hot_mode_dev_cycle_ios__benchmark/test_stdout
    
    Shows that it uninstalled and then tried debugging and failed, which would make sense since the app wasn't installed anymore.
    ```
    [2023-09-11 18:02:24.555646] [STDOUT] stdout: [   +6 ms] Lost connection to device. Trying to connect again...
    [2023-09-11 18:02:24.556949] [STDOUT] stdout: [   +1 ms] executing: /opt/s/w/ir/x/w/recipe_cleanup/tmp53fs1szo/flutter sdk/bin/cache/artifacts/libimobiledevice/idevicesyslog -u 00008030-00144DA10185402E
    [2023-09-11 18:02:24.557323] [STDOUT] stdout: [        ] executing: script -t 0 /dev/null /opt/s/w/ir/x/w/recipe_cleanup/tmp53fs1szo/flutter sdk/bin/cache/artifacts/ios-deploy/ios-deploy --id 00008030-00144DA10185402E --bundle build/ios/iphoneos/Flutter Gallery.app --app_deltas build/ios/app-delta --uninstall --noinstall --debug --no-wifi --args --enable-dart-profiling --disable-vm-service-publication --enable-checked-mode --verify-entry-points
    [2023-09-11 18:02:24.578010] [STDOUT] stdout: [  +20 ms] [....] Waiting for iOS device to be connected
    [2023-09-11 18:02:24.712631] [STDOUT] stdout: [ +134 ms] [....] Using 00008030-00144DA10185402E (N104AP, iPhone 11, iphoneos, arm64e, 16.2, 20C65) a.k.a. 'iPhone 11'.
    [2023-09-11 18:02:24.712725] [STDOUT] stdout: [        ] ------ Uninstall phase ------
    [2023-09-11 18:02:24.818293] [STDOUT] stdout: [ +105 ms] [ OK ] Uninstalled package with bundle id io.flutter.examples.gallery
    [2023-09-11 18:02:24.906833] [STDOUT] stdout: [  +88 ms] ------ Debug phase ------
    [2023-09-11 18:02:24.906924] [STDOUT] stdout: [        ] Starting debug of 00008030-00144DA10185402E (N104AP, iPhone 11, iphoneos, arm64e, 16.2, 20C65) a.k.a. 'iPhone 11' connected through USB...
    [2023-09-11 18:02:25.285252] [STDOUT] stdout: [ +378 ms] [  0%] Looking up developer disk image
    [2023-09-11 18:02:25.529937] [STDOUT] stdout: [ +244 ms] [ 90%] Mounting developer disk image
    [2023-09-11 18:02:25.545261] [STDOUT] stdout: [  +15 ms] [ 95%] Developer disk image already mounted
    [2023-09-11 18:02:25.587923] [STDOUT] stdout: [  +42 ms] Detected path to iOS debug symbols: "Symbol Path: /Users/swarming/Library/Developer/Xcode/iOS DeviceSupport/16.2 (20C65) arm64e/Symbols"
    [2023-09-11 18:02:25.857177] [STDOUT] stdout: [ +269 ms] Script started, output file is /dev/null
    [2023-09-11 18:02:25.857259] [STDOUT] stdout: [        ] Script done, output file is /dev/null
    [2023-09-11 18:02:25.857511] [STDOUT] stdout: [        ] ios-deploy exited with code 0
    [2023-09-11 18:02:25.858066] [STDOUT] stderr: [        ] Could not run build/ios/iphoneos/Flutter Gallery.app on 00008030-00144DA10185402E.
    [2023-09-11 18:02:25.858130] [STDOUT] stderr: [        ] Try launching Xcode and selecting "Product > Run" to fix the problem:
    [2023-09-11 18:02:25.858214] [STDOUT] stderr: [        ]   open ios/Runner.xcworkspace
    [2023-09-11 18:02:25.858537] [STDOUT] stdout: [        ] Installing and launching... (completed in 52.4s)
    [2023-09-11 18:02:25.858956] [STDOUT] stderr: [        ] Error launching application on iPhone 11.
    ```
    vashworth authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    abf8361 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    56cbf3e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    658710b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2396a41 View commit details
    Browse the repository at this point in the history
  9. Enable private field promotion for framework (#134473)

    New feature in upcoming Dart 3.2. See dart-lang/language#2020. Feature is enabled by bumping the min SDK version to 3.2.
    
    Part of #134476.
    goderbauer authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    da0f9a9 View commit details
    Browse the repository at this point in the history
  10. Access to fragment in router state on page refresh (#131123)

    This PR fixes the issue #108614 
    Particularly this behaviour #108614 (comment)
    vasilich6107 authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    43407cf View commit details
    Browse the repository at this point in the history
  11. Fixes focus traversal crash if the current node can't request focus (#…

    …134954)
    
    fixes #134854
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    chunhtai authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    f2050e8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5c6ef59 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a9183f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Configuration menu
    Copy the full SHA
    ab66f55 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from e1c784e to 589bde9 (16 revisions) (#134998)

    flutter-team-archive/engine@e1c784e...589bde9
    
    2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 4122791099ce to 744807d740c7 (1 revision) (flutter-team-archive/engine#46019)
    2023-09-19 jonahwilliams@google.com [Android] Add support for setting thread affinity based on core speed. (flutter-team-archive/engine#45673)
    2023-09-19 chinmaygarde@google.com [Impeller] Fix STB backend to account for max texture sizes. (flutter-team-archive/engine#46010)
    2023-09-19 matanlurey@users.noreply.github.com [Impeller] Hold the CommandPoolVK at a higher scope. (flutter-team-archive/engine#46013)
    2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 0c990ab9e097 to 4122791099ce (19 revisions) (flutter-team-archive/engine#46016)
    2023-09-18 kjlubick@users.noreply.github.com Add missing include of SkPath (flutter-team-archive/engine#45996)
    2023-09-18 chinmaygarde@google.com [Impeller] Respect max supported texture size when allocating glyph atlas texture. (flutter-team-archive/engine#45992)
    2023-09-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3_Lh8otTpmVuf-Zwb... to qy5FU4y6sx1FscCpd... (flutter-team-archive/engine#45998)
    2023-09-18 chris@bracken.jp Revert "[Windows] Update vsync on raster thread (#45310)" (flutter-team-archive/engine#46000)
    2023-09-18 matanlurey@users.noreply.github.com Provide a default `--target-variant` for `clang_tidy`. (flutter-team-archive/engine#45909)
    2023-09-18 ychris@google.com Revert "[ios] use python script to generate extension safe frameworks and code sign them" (flutter-team-archive/engine#46004)
    2023-09-18 john@johnmccutchan.com Disable HardwareBuffer backed Platform Views temporarily (flutter-team-archive/engine#45986)
    2023-09-18 john@johnmccutchan.com Tighten up ImageReaderPlatformViewRenderTarget code (flutter-team-archive/engine#45889)
    2023-09-18 ychris@google.com [ios] use python script to generate extension safe frameworks and code sign them (flutter-team-archive/engine#45781)
    2023-09-18 bdero@google.com Bump impeller-cmake to HEAD. (flutter-team-archive/engine#45953)
    2023-09-18 31859944+LongCatIsLooong@users.noreply.github.com [iOS] Remove selectionDidChange call in UndoManager (flutter-team-archive/engine#45657)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/mac-amd64 from 3_Lh8otTpmVu to qy5FU4y6sx1F
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8936504 View commit details
    Browse the repository at this point in the history
Loading