Visitar URL original
[Pigeon] renamed 'setupPigeon' to 'configurePigeon' (#142) · flutter/packages@8909df9 · GitHub
Skip to content

Commit 8909df9

Browse files
authored
[Pigeon] renamed 'setupPigeon' to 'configurePigeon' (#142)
1 parent 18298c6 commit 8909df9

5 files changed

Lines changed: 12 additions & 8 deletions

File tree

‎packages/pigeon/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.1.0-experimental.8
2+
3+
* Renamed `setupPigeon` to `configurePigeon`.
4+
15
## 0.1.0-experimental.7
26

37
* Suppressed or got rid of warnings in generated Dart code.

‎packages/pigeon/lib/pigeon_lib.dart‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -261,18 +261,18 @@ options:
261261
return result;
262262
}
263263

264-
/// Crawls through the reflection system looking for a setupPigeon method and
264+
/// Crawls through the reflection system looking for a configurePigeon method and
265265
/// executing it.
266-
static void _executeSetupPigeon(PigeonOptions options) {
266+
static void _executeConfigurePigeon(PigeonOptions options) {
267267
for (LibraryMirror library in currentMirrorSystem().libraries.values) {
268268
for (DeclarationMirror declaration in library.declarations.values) {
269269
if (declaration is MethodMirror &&
270-
MirrorSystem.getName(declaration.simpleName) == 'setupPigeon') {
270+
MirrorSystem.getName(declaration.simpleName) == 'configurePigeon') {
271271
if (declaration.parameters.length == 1 &&
272272
declaration.parameters[0].type == reflectClass(PigeonOptions)) {
273273
library.invoke(declaration.simpleName, <dynamic>[options]);
274274
} else {
275-
print('warning: invalid \'setupPigeon\' method defined.');
275+
print('warning: invalid \'configurePigeon\' method defined.');
276276
}
277277
}
278278
}
@@ -285,7 +285,7 @@ options:
285285
final Pigeon pigeon = Pigeon.setup();
286286
final PigeonOptions options = Pigeon.parseArgs(args);
287287

288-
_executeSetupPigeon(options);
288+
_executeConfigurePigeon(options);
289289

290290
if (options.input == null || options.dartOut == null) {
291291
print(usage);

‎packages/pigeon/pigeons/host2flutter.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ abstract class Api {
1717
SearchReply search(SearchRequest request);
1818
}
1919

20-
void setupPigeon(PigeonOptions options) {
20+
void configurePigeon(PigeonOptions options) {
2121
options.objcOptions.prefix = 'AC';
2222
}

‎packages/pigeon/pigeons/message.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ abstract class NestedApi {
2929
SearchReply search(Nested nested);
3030
}
3131

32-
void setupPigeon(PigeonOptions options) {
32+
void configurePigeon(PigeonOptions options) {
3333
options.objcOptions.prefix = 'AC';
3434
options.javaOptions.package = 'dev.flutter.aaclarke.pigeon';
3535
}

‎packages/pigeon/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: pigeon
2-
version: 0.1.0-experimental.7
2+
version: 0.1.0-experimental.8
33
description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
44
homepage: https://github.com/flutter/packages/tree/master/packages/pigeon
55
dependencies:

0 commit comments

Comments
 (0)