FilesExpand file tree

main

/

UseNgSrc.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

28 lines (26 loc) · 1.04 KB

main

/

UseNgSrc.ql

Copy path

Top

File metadata and controls

• Code
• Blame

28 lines (26 loc) · 1.04 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

/**

* @name Use of AngularJS markup in URL-valued attribute

* @description Using AngularJS markup in an HTML attribute that references a URL

* (such as 'href' or 'src') may cause the browser to send a request

* with an invalid URL.

* @kind problem

* @problem.severity warning

* @precision very-high

* @id js/angular/expression-in-url-attribute

* @tags quality

* reliability

* correctness

* frameworks/angularjs

*/

import javascript

from HTML::Attribute attr, string name

where

name = attr.getName() and

// only flag URL-valued attributes...

(name = "href" or name = "src" or name = "srcset") and

// ...where the value contains some interpolated expressions

attr.getValue().matches("%{{%}}") and

// check that there is at least one use of an AngularJS attribute directive nearby

// (`{{...}}` is used by other templating frameworks as well)

any(AngularJS::DirectiveInstance d).getATarget().getElement().getRoot() = attr.getRoot()

select attr, "Use 'ng-" + name + "' instead of '" + name + "'."