FilesExpand file tree

main

/

ClobberingVarInit.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

30 lines (28 loc) · 1.08 KB

main

/

ClobberingVarInit.ql

Copy path

Top

File metadata and controls

• Code
• Blame

30 lines (28 loc) · 1.08 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

/**

* @name Conflicting variable initialization

* @description If a variable is declared and initialized twice inside the same variable declaration

* statement, the second initialization immediately overwrites the first one.

* @kind problem

* @problem.severity error

* @id js/variable-initialization-conflict

* @tags quality

* reliability

* correctness

* external/cwe/cwe-563

* @precision very-high

*/

import javascript

import semmle.javascript.RestrictedLocations

from DeclStmt vds, VariableDeclarator vd1, VariableDeclarator vd2, int i, int j, Variable v

where

vd1 = vds.getDecl(i) and

vd2 = vds.getDecl(j) and

v = vd1.getBindingPattern().getAVariable() and

v = vd2.getBindingPattern().getAVariable() and

i < j and

// exclude a somewhat common pattern where the first declaration is used as a temporary

exists(Expr e1, Expr e2 | e1 = vd1.getInit() and e2 = vd2.getInit() |

not v.getAnAccess().getParentExpr*() = e2

)

select vd2.(FirstLineOf), "This initialization of " + v.getName() + " overwrites an $@.", vd1,

"earlier initialization"