Visitar URL original
could it be pageable for searching · Issue #562 · github-tools/github · GitHub
Skip to content

could it be pageable for searching #562

Open
#596
Open
could it be pageable for searching#562
#596
Assignees
j-rewerts
Labels
PRs welcomeenhancementneeds tests

Description

@ghost
ghost
opened on May 6, 2019

#367
it is slow due to search for all items ,

Activity

  1. j-rewerts
    added
    enhancement
    needs tests
    PRs welcome
    on May 6, 2019

  2. j-rewerts commented on May 6, 2019

    @j-rewerts
    j-rewerts
    on May 6, 2019
    Member

    Yeah makes sense. It looks like we call the Requestable._requestAllPages function. If we used this function, you could pass through a page token as an option.

    I'm open to a PR!

  3. j-rewerts commented on May 6, 2019

    @j-rewerts
    j-rewerts
    on May 6, 2019
    Member

    @WJXHenry, @kylejeske Let me know if you want to take this on.

  4. WJXHenry commented on May 7, 2019

    @WJXHenry
    WJXHenry
    on May 7, 2019
    Contributor

    @j-rewerts Sure, I'll be happy to take this on!

  5. j-rewerts
    self-assigned this
    on Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

PRs welcomeenhancementneeds tests

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions