gren changelog not finding all releases #308

Activity

1. paul-uz commented on Nov 23, 2021

   

   paul-uz

   on Nov 23, 2021

   Author

   More actions

   I tried with --limit 100 but the debug info still says 30

   gren changelog -o -D prs --limit 100 -B
   
   Options: 
   Tags: empty
   Prefix: empty
   Template: [object Object]
   Prerelease: false
   Generate: false
   Quiet: false
   Override: true
   Debug: true
   Ignore labels: empty
   Ignore issues with: empty
   Ignore commits with: empty
   Group by: false
   Milestone match: Release {{tag_name}}
   Changelog filename: CHANGELOG.md
   Username: Foobar
   Repo: XYZ
   Token: XXX
   Limit: 30
   Data source: prs
   Include messages: commits
   Ignore tags with: empty
   
2. paul-uz commented on Nov 23, 2021

   

   paul-uz

   on Nov 23, 2021

   Author

   More actions

   Limit does work, for numbers <= 99. As soon as you try 100, it defaults back to 30
3. mv-coder commented on Nov 26, 2021

   

   mv-coder

   on Nov 26, 2021

   More actions

   That is, because there is a MAX_TAGS_LIMIT = 99 in https://github.com/github-tools/github-release-notes/blob/master/lib/src/Gren.js. If you go beyond that, it will revert to the default TAGS_LIMIT = 30.
4. paul-uz commented on Nov 26, 2021

   

   paul-uz

   on Nov 26, 2021

   Author

   More actions

   Well, thats a bit daft isn't it. And not mentioned in the documentation 🙄

   👍React with 👍2Reacted by Mike Holloway and Tomás Henríquez