Visitar URL original
Comparing main...pr-288 · gitpod-io/leeway · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gitpod-io/leeway
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: gitpod-io/leeway
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr-288
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 38 files changed
  • 2 contributors

Commits on Nov 20, 2025

  1. feat: add OpenTelemetry tracing with build and package spans

    Add OpenTelemetry infrastructure for distributed tracing with support
    for W3C Trace Context propagation from CI systems.
    
    - Add telemetry package with tracer initialization, shutdown, and trace context parsing
    - Implement OTelReporter with build and package span creation
    - Add CLI flags: --otel-endpoint, --trace-parent, --trace-state
    - Capture build metrics, package timing, and GitHub Actions context
    - Thread-safe concurrent package builds with RWMutex
    - Graceful degradation when tracing fails
    - Comprehensive tests with in-memory exporters
    - Documentation in docs/observability.md and README.md
    
    Closes CLC-2106
    
    Co-authored-by: Ona <no-reply@ona.com>
    corneliusludmann and ona-agent committed Nov 20, 2025
    Configuration menu
    Copy the full SHA
    aa8c20c View commit details
    Browse the repository at this point in the history
  2. feat: add docker-in-docker to devcontainer

    Enable Docker support in the development container for building and
    testing Docker packages.
    
    Co-authored-by: Ona <no-reply@ona.com>
    corneliusludmann and ona-agent committed Nov 20, 2025
    Configuration menu
    Copy the full SHA
    14a1ae2 View commit details
    Browse the repository at this point in the history
  3. fix: properly shutdown OpenTelemetry tracer after build completes

    Move tracer shutdown from getBuildOpts to build command Run function
    to ensure spans are flushed after the build completes, not immediately
    after getBuildOpts returns.
    
    - Change getBuildOpts to return shutdown function
    - Update all callers to handle the new return value
    - Set OTEL_EXPORTER_OTLP_ENDPOINT from CLI flag before InitTracer
    
    Tested with Jaeger and confirmed traces are now properly sent.
    
    Co-authored-by: Ona <no-reply@ona.com>
    corneliusludmann and ona-agent committed Nov 20, 2025
    Configuration menu
    Copy the full SHA
    9da6e65 View commit details
    Browse the repository at this point in the history
  4. chore: lint and format OpenTelemetry code

    - Fix errcheck warnings in test files (check tp.Shutdown errors)
    - Fix errcheck warnings for os.Setenv/Unsetenv in tests
    - Run go fmt on modified files
    
    Co-authored-by: Ona <no-reply@ona.com>
    corneliusludmann and ona-agent committed Nov 20, 2025
    Configuration menu
    Copy the full SHA
    7a9f91c View commit details
    Browse the repository at this point in the history
  5. chore: run go fmt on entire codebase

    Format all Go files to ensure consistent code style.
    
    Co-authored-by: Ona <no-reply@ona.com>
    corneliusludmann and ona-agent committed Nov 20, 2025
    Configuration menu
    Copy the full SHA
    bb87825 View commit details
    Browse the repository at this point in the history
  6. test: add GitHub attributes coverage tests

    Add comprehensive tests for GitHub Actions environment variable handling:
    - TestOTelReporter_GitHubAttributes: Verifies all 10 GitHub attributes
      are correctly added to spans when running in GitHub Actions
    - TestOTelReporter_NoGitHubAttributes: Verifies no GitHub attributes
      are added when not running in GitHub Actions
    
    Coverage improvement:
    - addGitHubAttributes: 9.1% → 100%
    
    Co-authored-by: Ona <no-reply@ona.com>
    corneliusludmann and ona-agent committed Nov 20, 2025
    Configuration menu
    Copy the full SHA
    7a19a2b View commit details
    Browse the repository at this point in the history
  7. refactor: improve OTLP endpoint configuration handling

    Change InitTracer to accept endpoint as parameter instead of reading
    from environment variable. This improves testability and follows
    separation of concerns.
    
    Changes:
    - InitTracer now takes endpoint as parameter: InitTracer(ctx, endpoint)
    - Remove confusing env var manipulation in cmd/build.go
    - Simplify test (no need to manipulate environment)
    - Make configuration flow clearer: flag → function parameter
    
    Benefits:
    - Easier to test (no env var side effects)
    - Clearer API (explicit parameter vs implicit env var)
    - Consistent with other reporters (e.g., SegmentReporter)
    - No circular dependency between flag default and env var
    
    Co-authored-by: Ona <no-reply@ona.com>
    corneliusludmann and ona-agent committed Nov 20, 2025
    Configuration menu
    Copy the full SHA
    d36898a View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2025

  1. feat: add TLS configuration and fix version retrieval for OTel

    - Add OTEL_EXPORTER_OTLP_INSECURE env var and --otel-insecure flag
    - Default to secure TLS connections (production-ready)
    - Fix version retrieval to use actual leeway.Version
    - Update documentation with Honeycomb production examples
    - Add TLS configuration section to observability docs
    
    Addresses review feedback on PR #288
    
    Co-authored-by: Ona <no-reply@ona.com>
    corneliusludmann and ona-agent committed Nov 21, 2025
    Configuration menu
    Copy the full SHA
    c1c975e View commit details
    Browse the repository at this point in the history
Loading