Repository navigation
Wrong type annotation on Index.commit for parent_commits #1866
Description
Activity
Thanks for reporting!
I think this issue might be fixed once #1859, which touches on what constitutes
Commit_ish. @EliahKagan certainly has a much better understanding of the matter though, and I wouldn't want the PR to become larger than it has to be just to include an actual fix (if it's not fixed naturally).Great! Wow, just understood, that @Byron at stack overflow threads related to GitPython is actually the package maintainer, so silly of me :). Nice to meet, looking forward PR
With
GitPython==3.1.42one can observe following annotation ofparent_commitsargument toIndexFile.commit([1]):which is obviously not correct, because that argument just passed unmodified downwards to
Commit.create_from_tree, which has following annotation instead ([2]):That leads to nasty Mypy warnings when one's trying to use
IndexFile.commitwith anything different thanNone.[1] - https://github.com/gitpython-developers/GitPython/blob/3.1.42/git/index/base.py#L1080
[2] - https://github.com/gitpython-developers/GitPython/blob/3.1.42/git/objects/commit.py#L506