Visitar URL original
Add a unit test for the usage of `restrict_to` and `restriction_idx_key` in `select_in_dataset` of `GoldSelector` · Issue #310 · goldener-data/goldener · GitHub
Skip to content

Add a unit test for the usage of restrict_to and restriction_idx_key in select_in_dataset of GoldSelector #310

Closed

Description

@Yann-CV

Context & Problem

In GoldSelector, the usage of restrict_to and restriction_idx_key in select_in_dataset is not tested (even though it is tested through the GoldSplitter with clusterization.

Let's make our coverage better

Proposed Solution

Add unit tests for select_in_dataset when specifying restrict_to and restriction_idx_key!

Activity

  1. added theissue type on Aug 24, 2026
  2. added
    help wantedExtra attention is needed
    readyspecified by a core maintainer
    testcomplete the test suite of Goldener
    on Aug 24, 2026
  3. SHEKHAR-Y commented on Aug 31, 2026

    @SHEKHAR-Y

    Hi! @Yann-CV I'd like to work on this issue. I’ll add direct unit tests for restrict_to and restriction_idx_key in select_in_dataset and make sure the existing test suite continues to pass.

  4. Yann-CV commented on Aug 31, 2026

    @Yann-CV
    ContributorAuthor

    Sure go ahead @SHEKHAR-Y! Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

good first issueGood for newcomershelp wantedExtra attention is neededreadyspecified by a core maintainertestcomplete the test suite of Goldener

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions