This repository was archived by the owner on Aug 25, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 25, 2026. It is now read-only.
No way to specify python_gapic_opt flag with py_gapic_library rule #390
Description
We need to replicate the following protoc invocation from Bazel rule py_gapic_library. In particular, there's no current way to set --python_gapic_opt to the desired value below:
protoc google/ads/googleads/${VERSION}/**/*.proto \
--proto_path="${COMMON_PROTOS_PATH}" \
--proto_path=. \
--python_gapic_out=${OUTPUT_DIR} \
--plugin=${GAPIC_GENERATOR_PATH}/gapic/cli/generate.py=python_gapic \
--python_gapic_opt="old-naming,lazy-import,python-gapic-name=${GAPIC_NAME},python-gapic-templates=${GAPIC_GENERATOR_PATH}/gapic/ads-template"
where one var is custom:
GAPIC_NAME is googleads.
And the other vars are what you'd expect:
COMMON_PROTOS_PATH is api-common-protos dependencies
GAPIC_GENERATOR_PATH is root of gapic-generator-python
Activity
aohren commentedon Apr 14, 2020
Output from a
bazel build --verbose_failuresrun:https://drive.google.com/a/google.com/file/d/1oKBkNbG6_wjwlNvS8F34CHQFBmLIpM8N/view?usp=sharing
BenRKarl commentedon Apr 14, 2020
@aohren there's an updated value for
python-gapic-templatesnow, it should point to the/gapic/ads-templatesdirectory on the master branch of this repository.aohren commentedon Apr 14, 2020
@BenRKarl thanks for that. I've edited the original issue in-place to reflect the updated protoc arguments.
feat: Make GAPIC Bazel rules production ready (#402)
feat: Add opt_args to common_proto_library
feat: Add opt_args to py_gapic_library (#411)
vam-google commentedon May 10, 2020
Should be fixed in #411. Closing.
software-dov commentedon May 13, 2020
Should be fixed by #402
feat: Make GAPIC Bazel rules production ready (#402)
feat: Add opt_args to py_gapic_library (#411)