Visitar URL original
feat: support mtls env variables by arithmetic1728 · Pull Request #589 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

feat: support mtls env variables - #589

Merged
software-dov merged 6 commits into
masterfrom
mtls
Sep 10, 2020
Merged

feat: support mtls env variables#589
software-dov merged 6 commits into
masterfrom
mtls

Conversation

@arithmetic1728

@arithmetic1728 arithmetic1728 commented Sep 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Implement the two mtls env variables mentioned in https://google.aip.dev/auth/4114

New behavior summary:
(1) GOOGLE_API_USE_CLIENT_CERTIFICATE env variable:
Values:
"true": use client cert if exists
"false" (default): never use client cert, even if it exists or it is explicitly provided by user
(2) GOOGLE_API_USE_MTLS_ENDPOINT env variable:
Values:
"never": use regular endpoint
"always": use mtls endpoint
"auto" (default): auto switch to mtls endpoint, if client cert exists and we are allowed to use it (controlled by GOOGLE_API_USE_CLIENT_CERTIFICATE)

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 4, 2020
@codecov

codecov Bot commented Sep 4, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #589 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #589   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1519      1519           
  Branches       309       309           
=========================================
  Hits          1519      1519

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad8888...53868bf. Read the comment docs.

@arithmetic1728
arithmetic1728 marked this pull request as ready for review September 4, 2020 00:40
@arithmetic1728

arithmetic1728 commented Sep 9, 2020

Copy link
Copy Markdown
Contributor Author

@software-dov @busunkim96 Please take a look at this PR when you have time. Since it has a breaking change, it is nice to have client libs not yet converted to pick up this change as early as possible. Thanks!

software-dov
software-dov reviewed Sep 9, 2020
View reviewed changes

@software-dov software-dov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are a few things I want to discuss before approving.

Comment thread gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2 Resolved
Comment thread gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2 Resolved
Comment thread gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2 Resolved
Comment thread gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2 Resolved
Comment thread gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2 Resolved
Comment thread gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 Resolved
busunkim96
busunkim96 reviewed Sep 9, 2020
View reviewed changes
Comment thread gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2 Resolved
Comment thread gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2 Resolved
@software-dov
software-dov merged commit b19026d into master Sep 10, 2020
@arithmetic1728
arithmetic1728 deleted the mtls branch September 10, 2020 20:24
This was referenced Jan 18, 2022
Merged
Closed
This was referenced Jan 26, 2022
Closed
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@software-dov software-dov software-dov left review comments
@busunkim96 busunkim96 busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arithmetic1728 @software-dov @busunkim96