Visitar URL original
Some tests are missing port in comparison · Issue #872 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

Some tests are missing port in comparison #872

Closed
#1133
#873
Closed
Some tests are missing port in comparison#872
#1133
#873
Assignees
busunkim96
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@busunkim96
busunkim96
opened on May 10, 2021

Noticed in googleapis/python-aiplatform#377

Correct:

gapic-generator-python/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines 1628 to 1629 in 5339db1

create_channel.assert_called_with(
"{{ host }}{% if ":" not in service.host %}:443{% endif %}",

Missing:

gapic-generator-python/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines 1705 to 1706 in 5339db1

create_channel.assert_called_with(
"{{ host }}",

Activity

  1. busunkim96
    added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on May 10, 2021
  2. busunkim96
    self-assigned this
    on May 10, 2021
  3. busunkim96
    changed the title [-]Some tests are missing optional port in comparison[/-] [+]Some tests are missing port in comparison[/+] on May 10, 2021
  4. gcf-merge-on-green
    closed this as completedin #873on May 12, 2021
  5. gcf-merge-on-green
    added a commit that references this issue on May 12, 2021

    fix: fix incorrectly referenced exceptions, add missing port to tests (…

    40078c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions