Visitar URL original
feat: Support alternative http bindings in the gapic schema. by kbandes · Pull Request #993 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

feat: Support alternative http bindings in the gapic schema. - #993

Merged
software-dov merged 6 commits into
googleapis:masterfrom
kbandes:kbandes-xcode
Sep 15, 2021
Merged

feat: Support alternative http bindings in the gapic schema.#993
software-dov merged 6 commits into
googleapis:masterfrom
kbandes:kbandes-xcode

Conversation

@kbandes

@kbandes kbandes commented Sep 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This completes part of yon-mg's PR, #776. The template changes will be in a separate PR.

@kbandes
kbandes requested a review from a team September 14, 2021 19:03
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2021
@kbandes kbandes changed the title Support alternative http bindings in the gapic schema. feat: Support alternative http bindings in the gapic schema. Sep 14, 2021
software-dov
software-dov reviewed Sep 14, 2021
View reviewed changes

@software-dov software-dov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: are these additions intended to replace or complement the existing http_opt property? I think we should probably have only one. The names are too similar to be easily distinguished without reading the code.

Comment thread gapic/schema/wrappers.py Resolved
Comment thread gapic/schema/wrappers.py Resolved
Comment thread gapic/schema/wrappers.py Resolved
Comment thread gapic/schema/wrappers.py Resolved
kbandes
kbandes commented Sep 15, 2021
View reviewed changes
Comment thread gapic/schema/wrappers.py Resolved
@software-dov
software-dov merged commit 041a726 into googleapis:master Sep 15, 2021
gcf-merge-on-green Bot pushed a commit that referenced this pull request Sep 29, 2021
@release-please
chore: release 0.52.0 (#995)
0c40194 
🤖 I have created a release \*beep\* \*boop\*
---
## [0.52.0](https://www.github.com/googleapis/gapic-generator-python/compare/v0.51.2...v0.52.0) (2021-09-29)


### Features

* Support alternative http bindings in the gapic schema. ([#993](https://www.github.com/googleapis/gapic-generator-python/issues/993)) ([041a726](https://www.github.com/googleapis/gapic-generator-python/commit/041a726b818cd67812d689c23757f31ec9964d66))


### Bug Fixes

* improper types in pagers generation ([#970](https://www.github.com/googleapis/gapic-generator-python/issues/970)) ([bba3eea](https://www.github.com/googleapis/gapic-generator-python/commit/bba3eea5d45fe57c0395ceef30402ad7880013d7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 18, 2022
Merged
Closed
Closed
This was referenced Jan 26, 2022
Closed
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@software-dov software-dov software-dov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kbandes @software-dov