Visitar URL original
feat(bigtable): Async refresh dry run in parallel with sync refresh by bhshkh · Pull Request #11066 · googleapis/google-cloud-go · GitHub
Skip to content

feat(bigtable): Async refresh dry run in parallel with sync refresh - #11066

Merged
bhshkh merged 17 commits into
googleapis:mainfrom
bhshkh:feat/cbt-async-refresh-dry-run
Dec 11, 2024
Merged

feat(bigtable): Async refresh dry run in parallel with sync refresh#11066
bhshkh merged 17 commits into
googleapis:mainfrom
bhshkh:feat/cbt-async-refresh-dry-run

Conversation

@bhshkh

@bhshkh bhshkh commented Oct 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Async refresh token and record any errors to debug_tags metrics with tag field set to "async_refresh_dryn_run"
Corresponding google-api-go-client PR: googleapis/google-api-go-client#2849

Fixes: b/372244283

This PR also updates conformance test Go version. Currently, conformance tests fail to run with error:

go: ../go.mod requires go >= 1.22.7 (running go 1.22.5; GOTOOLCHAIN=local)

@bhshkh
bhshkh changed the base branch from main to feat/async-dry-run October 31, 2024 00:41
@bhshkh bhshkh changed the title More logs feat(bigtable): Async refresh dry run in parallel with sync refresh Oct 31, 2024
@bhshkh bhshkh mentioned this pull request Oct 31, 2024
Merged
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Oct 31, 2024
@bhshkh
bhshkh marked this pull request as ready for review November 18, 2024 18:56
@bhshkh
bhshkh requested review from a team November 18, 2024 18:56
@bhshkh
bhshkh changed the base branch from async-refresh-dry-run to main November 18, 2024 18:57
@bhshkh
bhshkh requested a review from mutianf November 20, 2024 01:37
@bhshkh

bhshkh commented Nov 20, 2024

Copy link
Copy Markdown
Contributor Author

Facing #11161 when running multiple ReadRow operations in parallel. Will work on fixing it

mutianf
mutianf reviewed Nov 27, 2024
View reviewed changes
Comment thread bigtable/bigtable.go Outdated
Comment thread bigtable/metrics.go Outdated
@bhshkh
bhshkh enabled auto-merge (squash) December 4, 2024 19:43
@bhshkh
bhshkh requested a review from mutianf December 4, 2024 19:43
@bhshkh

bhshkh commented Dec 4, 2024

Copy link
Copy Markdown
Contributor Author

Facing #11161 when running multiple ReadRow operations in parallel. Will work on fixing it

This has been fixed in oauth2adapt 0.2.6 . oauth2adapt is consumed in google.golang.org/api 0.210.0
So, I have updated go.mod to use google.golang.org/api 0.210.0

mutianf
mutianf requested changes Dec 4, 2024
View reviewed changes
Comment thread bigtable/metrics_util.go Outdated
Comment thread bigtable/metrics_util.go Outdated
Comment thread bigtable/metrics.go Outdated
@bhshkh
bhshkh requested a review from mutianf December 5, 2024 22:40
@bhshkh
bhshkh merged commit 169e309 into googleapis:main Dec 11, 2024
@bhshkh
bhshkh deleted the feat/cbt-async-refresh-dry-run branch December 11, 2024 19:13
@release-please release-please Bot mentioned this pull request Dec 11, 2024
Merged
gkevinzheng
gkevinzheng reviewed Dec 11, 2024
View reviewed changes
Comment thread bigtable/bigtable.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mutianf mutianf mutianf approved these changes
+1 more reviewer
@gkevinzheng gkevinzheng gkevinzheng left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhshkh @mutianf @gkevinzheng