Visitar URL original
fix(bigtable): Mutate groups even after first error by bhshkh · Pull Request #11434 · googleapis/google-cloud-go · GitHub
Skip to content

fix(bigtable): Mutate groups even after first error - #11434

Merged
bhshkh merged 11 commits into
googleapis:mainfrom
bhshkh:fix/cbt-TestMutateRows_Generic_DeadlineExceeded
Jan 15, 2025
Merged

bhshkh merged 11 commits into
googleapis:mainfrom
bhshkh:fix/cbt-TestMutateRows_Generic_DeadlineExceeded

Conversation

@bhshkh

@bhshkh bhshkh commented Jan 10, 2025 •

Copy link
Copy Markdown
Contributor

This PR has 2 changes

  1. If the number of mutations is greater than maxMutations, the library breaks down the mutations into smaller groups. If any of the group fails, no further groups are tried and the first error seen is returned. In this PR, this behaviour has been changed by trying to apply all further groups even if one of the group fails.
  2. If the MutateRowsRequest fails without returning any response (e.g. in case of DeadlineExceeded error), the per mutation errors are nil. In this PR, this behaviour has been changed to set per mutation error.

@bhshkh
bhshkh requested review from a team January 10, 2025 19:32
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Jan 10, 2025
@bhshkh
bhshkh requested a review from gkevinzheng January 10, 2025 19:33
@bhshkh
bhshkh enabled auto-merge (squash) January 10, 2025 22:12
@bhshkh
bhshkh disabled auto-merge January 14, 2025 23:25
@bhshkh
bhshkh marked this pull request as draft January 14, 2025 23:25
@bhshkh
bhshkh marked this pull request as ready for review January 15, 2025 04:57
@bhshkh
bhshkh requested a review from andre-sampaio January 15, 2025 04:59
@bhshkh
bhshkh enabled auto-merge (squash) January 15, 2025 19:17
@bhshkh
bhshkh disabled auto-merge January 15, 2025 19:21
@bhshkh
bhshkh enabled auto-merge (squash) January 15, 2025 21:59
@bhshkh
bhshkh merged commit 6ffe32b into googleapis:main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants