Visitar URL original
feat(bigtable): Add Execute method to execute GoogleSQL queries by bhshkh · Pull Request #11883 · googleapis/google-cloud-go · GitHub
Skip to content

feat(bigtable): Add Execute method to execute GoogleSQL queries - #11883

Merged
bhshkh merged 14 commits into
googleapis:mainfrom
bhshkh:feature/cbt-btql-execute-01
Mar 27, 2025
Merged

feat(bigtable): Add Execute method to execute GoogleSQL queries#11883
bhshkh merged 14 commits into
googleapis:mainfrom
bhshkh:feature/cbt-btql-execute-01

Conversation

@bhshkh

@bhshkh bhshkh commented Mar 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

To execute a SQL query, user needs to

  1. Prepare query
    The "Prepare" step takes a SQL query text and some additional information and returns some state and an execution plan. Essentially, it processes the query and sets up what is needed to run it, before the actual execution of the query occurs.
  2. Bind parameters
  3. Execute the query

This PR adds support for the third step.
Most of the implementation of func (bs *BoundStatement) execute is similar to readrows
method on ResultRow to access the results will be added in next PR: #11924 .

More context:

@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Mar 20, 2025
@bhshkh
bhshkh force-pushed the feature/cbt-btql-execute-01 branch from 5328d3a to f7476eb Compare March 20, 2025 13:06
@bhshkh
bhshkh force-pushed the feature/cbt-btql-execute-01 branch from 8eb4ea1 to e8ea433 Compare March 25, 2025 08:33
@bhshkh
bhshkh marked this pull request as ready for review March 25, 2025 08:47
@bhshkh
bhshkh requested a review from igorbernstein2 as a code owner March 25, 2025 08:47
@bhshkh
bhshkh requested review from a team March 25, 2025 08:47
gkevinzheng
gkevinzheng reviewed Mar 25, 2025
View reviewed changes
Comment thread bigtable/bigtable.go Outdated
Comment thread bigtable/bigtable.go
jackdingilian
jackdingilian requested changes Mar 25, 2025
View reviewed changes
Comment thread bigtable/bigtable.go Outdated
Comment thread bigtable/bigtable.go Outdated
Comment thread bigtable/bigtable.go Outdated
Comment thread bigtable/bigtable.go Outdated
Comment thread bigtable/bigtable.go Outdated
Comment thread bigtable/bigtable.go
jackdingilian
jackdingilian reviewed Mar 25, 2025
View reviewed changes
Comment thread bigtable/bigtable.go Outdated
jackdingilian
jackdingilian reviewed Mar 25, 2025
View reviewed changes
Comment thread bigtable/bigtable.go Outdated
@bhshkh
bhshkh enabled auto-merge (squash) March 25, 2025 19:14
jackdingilian
jackdingilian reviewed Mar 25, 2025
View reviewed changes
Comment thread bigtable/bigtable.go Outdated
jackdingilian
jackdingilian reviewed Mar 25, 2025
View reviewed changes
Comment thread bigtable/bigtable_test.go Outdated
jackdingilian
jackdingilian reviewed Mar 25, 2025
View reviewed changes
Comment thread bigtable/bigtable.go Outdated
@bhshkh
bhshkh requested a review from jackdingilian March 27, 2025 04:33
jackdingilian
jackdingilian requested changes Mar 27, 2025
View reviewed changes

@jackdingilian jackdingilian left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly Looking good, just want to resolve comment about potential race condition on refresh

Comment thread bigtable/bigtable.go Outdated
Comment thread bigtable/bigtable_test.go
@bhshkh
bhshkh requested a review from jackdingilian March 27, 2025 16:12
jackdingilian
jackdingilian reviewed Mar 27, 2025
View reviewed changes
Comment thread bigtable/bigtable.go Outdated
// Make a deep copy. Even if preparedStatement is refreshed, this wouldn't change
metadata: proto.Clone(metadata).(*btpb.ResultSetMetadata),
preparedQuery: query,
metadata: proto.Clone(ps.data.metadata).(*btpb.ResultSetMetadata),

@jackdingilian jackdingilian Mar 27, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is still a race here. If ps.data is updated between accessing the metadata and the preparedQuery.

We need to do
data = ps.data

return {
data.preparedQuery,
data.metadata,
...
}

@bhshkh bhshkh Mar 27, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@bhshkh
bhshkh merged commit 0e53dcd into googleapis:main Mar 27, 2025
@release-please release-please Bot mentioned this pull request Mar 27, 2025
Merged
@bhshkh bhshkh mentioned this pull request Mar 28, 2025
Merged
@bhshkh
bhshkh deleted the feature/cbt-btql-execute-01 branch June 17, 2025 11:00
@bhshkh bhshkh linked an issue Oct 8, 2025 that may be closed by this pull request
bigtable: GoogleSQL Bind, Prepare and Execute #13068
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackdingilian jackdingilian jackdingilian approved these changes
@igorbernstein2 igorbernstein2 Awaiting requested review from igorbernstein2
+1 more reviewer
@gkevinzheng gkevinzheng gkevinzheng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigtable: GoogleSQL Bind, Prepare and Execute

3 participants

@bhshkh @jackdingilian @gkevinzheng