Repository navigation
fix(bigtable): Ignore errors while creating monitoring client and disable metrics - #12708
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: bigtable
bhshkh
changed the title
bhshkh
changed the title
bhshkh
enabled auto-merge (squash)
August 15, 2025 19:34
hongalex
approved these changes
Aug 18, 2025
| debugTags metric.Int64Counter | ||
| } | ||
|
|
||
| // Returns error only if metricsProvider is of unknown type. Rest all errors are swallowed |
Member
There was a problem hiding this comment.
Trying to grok this, maybe meant to say "All other errors are swallowed with metrics disabled"
This was
linked to
issues
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any errors during creating monitoring client should not disrupt the normal functioning of the client. swallow all such errors
Context: b/432819321