Visitar URL original
fix(gapic-generator): restrict package discovery to gapic* namespace … · googleapis/google-cloud-python@b87776d · GitHub
Skip to content

Commit b87776d

Browse files
ohmayrohmayr
authored
fix(gapic-generator): restrict package discovery to gapic* namespace (#18030)
### Summary Previously, `setup.py` called `setuptools.find_namespace_packages(exclude=["docs", "tests"])` without wildcard glob patterns. When CI (`run_single_test.sh`) or local test runners created temporary virtual environments (such as `.venv-profiler` or `.nox`), `setuptools` mistook those hidden directories for library packages and attempted to package their contents, causing `pip install -e .` and CI profiling jobs to fail or take too long. ### Fix This PR updates `exclude` in `setup.py` to use wildcard glob patterns: ```python packages=setuptools.find_namespace_packages( exclude=["docs*", "tests*", "testing*", ".*", "bazel*", "rules_python_gapic*"] ),
1 parent dd2000d commit b87776d

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎packages/gapic-generator/setup.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@
6161
author="Google LLC",
6262
author_email="googleapis-packages@google.com",
6363
license="Apache-2.0",
64-
packages=setuptools.find_namespace_packages(exclude=["docs", "tests"]),
64+
packages=setuptools.find_namespace_packages(
65+
exclude=["docs*", "tests*", "testing*", ".*", "bazel*", "rules_python_gapic*"]
66+
),
6567
url=url,
6668
classifiers=[
6769
release_status,

0 commit comments

Comments
 (0)