Visitar URL original
feat: Enable Lossless Timestamps in BQ java client lib by whuffman36 · Pull Request #3589 · googleapis/java-bigquery · GitHub
Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

feat: Enable Lossless Timestamps in BQ java client lib - #3589

Merged
whuffman36 merged 4 commits into
mainfrom
timestamps
Dec 2, 2024
Merged

feat: Enable Lossless Timestamps in BQ java client lib#3589
whuffman36 merged 4 commits into
mainfrom
timestamps

Conversation

@whuffman36

@whuffman36 whuffman36 commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

With discovery revision 20240124 or later, the BQ discovery document now properly exposes the API functionality to use lossless timestamps (DataFormatOptions.UseInt64Timestamp). This can be supplied as part of the jobs.query request, as well as passed as arguments to tabledata.list / jobs.getQueryResults.

This change enables the toggling of lossless timestamps in the java client library for BQ. The former format is still usable and is used by default. Users must opt in to use this feature.

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Nov 21, 2024
@whuffman36
whuffman36 marked this pull request as ready for review November 21, 2024 01:23
@whuffman36
whuffman36 requested review from a team, PhongChuong, shollyman and suzmue and removed request for suzmue November 21, 2024 01:23
PhongChuong
PhongChuong reviewed Nov 25, 2024
View reviewed changes

@PhongChuong PhongChuong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just a few minor comments/change requests.

Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryJobConfiguration.java Resolved
Comment thread google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java Resolved
Comment thread google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java Resolved
Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/FieldValue.java Resolved
Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryOptions.java Resolved
Comment thread google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/QueryRequestInfoTest.java Resolved
@whuffman36
whuffman36 merged commit c0b874a into main Dec 2, 2024
@whuffman36
whuffman36 deleted the timestamps branch December 2, 2024 18:25
@release-please release-please Bot mentioned this pull request Dec 2, 2024
Merged
This was referenced Dec 17, 2024
Closed
Closed
Closed
@release-please release-please Bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shollyman shollyman Awaiting requested review from shollyman
1 more reviewer
@PhongChuong PhongChuong PhongChuong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whuffman36 @PhongChuong