Visitar URL original
fix: enable integration test for graal · googleapis/java-bigtable@8740ec4 · GitHub
Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

Commit 8740ec4

Browse files
committed
fix: enable integration test for graal
1 parent 5ab424c commit 8740ec4

3 files changed

Lines changed: 28 additions & 16 deletions

File tree

‎google-cloud-bigtable-stats/src/main/java/com/google/cloud/bigtable/stats/StatsWrapper.java‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@
2020
import com.google.api.core.InternalApi;
2121
import com.google.api.gax.tracing.SpanName;
2222
import io.opencensus.stats.Stats;
23+
import io.opencensus.stats.View;
24+
import io.opencensus.tags.TagKey;
2325
import java.util.ArrayList;
26+
import java.util.HashMap;
2427
import java.util.List;
2528
import java.util.Map;
2629
import java.util.stream.Collectors;
@@ -31,7 +34,6 @@
3134
*/
3235
@InternalApi("For internal use only")
3336
public class StatsWrapper {
34-
3537
public static StatsRecorderWrapper createRecorder(
3638
OperationType operationType, SpanName spanName, Map<String, String> statsAttributes) {
3739
return new StatsRecorderWrapper(
@@ -49,4 +51,16 @@ public static List<String> getOperationLatencyViewTagValueStrings() {
4951
.map(x -> x.asString())
5052
.collect(Collectors.toCollection(ArrayList::new));
5153
}
54+
55+
// A workaround to run BuiltinViewConstantsTest as integration test
56+
static Map<String, List<String>> getViewToTagMap() {
57+
Map<String, List<String>> map = new HashMap<>();
58+
for (View view : BuiltinViews.BIGTABLE_BUILTIN_VIEWS) {
59+
List<TagKey> tagKeys = view.getColumns();
60+
map.put(
61+
view.getName().asString(),
62+
tagKeys.stream().map(tagKey -> tagKey.getName()).collect(Collectors.toList()));
63+
}
64+
return map;
65+
}
5266
}

google-cloud-bigtable-stats/src/test/java/com/google/cloud/bigtable/stats/BuiltinViewConstantsTest.java renamed to google-cloud-bigtable-stats/src/test/java/com/google/cloud/bigtable/stats/ITBuiltinViewConstantsTest.java

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,21 @@
1717

1818
import static com.google.common.truth.Truth.assertWithMessage;
1919

20-
import io.opencensus.stats.View;
20+
import java.util.List;
21+
import java.util.Map;
2122
import org.junit.Test;
2223

23-
public class BuiltinViewConstantsTest {
24+
public class ITBuiltinViewConstantsTest {
2425
@Test
2526
public void testBasicTagsExistForAllViews() {
26-
for (View v : BuiltinViews.BIGTABLE_BUILTIN_VIEWS) {
27-
assertWithMessage(v.getName() + " should have all basic tags")
28-
.that(v.getColumns())
27+
Map<String, List<String>> viewToTagMap = StatsWrapper.getViewToTagMap();
28+
for (String view : viewToTagMap.keySet()) {
29+
System.out.println(view);
30+
System.out.println(viewToTagMap.get(view));
31+
assertWithMessage(view + " should have all basic tags")
32+
.that(viewToTagMap.get(view))
2933
.containsAtLeast(
30-
BuiltinMeasureConstants.PROJECT_ID,
31-
BuiltinMeasureConstants.INSTANCE_ID,
32-
BuiltinMeasureConstants.APP_PROFILE,
33-
BuiltinMeasureConstants.METHOD,
34-
BuiltinMeasureConstants.ZONE,
35-
BuiltinMeasureConstants.CLUSTER,
36-
BuiltinMeasureConstants.TABLE);
34+
"project_id", "instance_id", "app_profile", "method", "zone", "cluster", "table");
3735
}
3836
}
3937
}

‎google-cloud-bigtable-stats/src/test/java/com/google/cloud/bigtable/stats/StatsRecorderWrapperTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ public void testStreamingOperation() throws InterruptedException {
6060
ApiTracerFactory.OperationType.ServerStreaming,
6161
SpanName.of("Bigtable", "ReadRows"),
6262
ImmutableMap.of(
63-
BuiltinMeasureConstants.PROJECT_ID.getName(),
63+
"project_id",
6464
PROJECT_ID,
65-
BuiltinMeasureConstants.INSTANCE_ID.getName(),
65+
"instance_id",
6666
INSTANCE_ID,
67-
BuiltinMeasureConstants.APP_PROFILE.getName(),
67+
"app_profile",
6868
APP_PROFILE_ID),
6969
statsComponent.getStatsRecorder());
7070

0 commit comments

Comments
 (0)