Visitar URL original
fix: allow factory to export to different projects by mutianf · Pull Request #2374 · googleapis/java-bigtable · GitHub
Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

fix: allow factory to export to different projects - #2374

Merged
gcf-merge-on-green[bot] merged 7 commits into
googleapis:mainfrom
mutianf:factory
Dec 2, 2024
Merged

fix: allow factory to export to different projects#2374
gcf-merge-on-green[bot] merged 7 commits into
googleapis:mainfrom
mutianf:factory

Conversation

@mutianf

@mutianf mutianf commented Oct 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This fix removed the check on Bigtable project id and gets the BigtableTable resource project id directly from metrics attribute. BigtableDataClientFactory can create one client for multiple projects. Removing the check allows people using BigtableDataClientFactory to export to different projects.

@mutianf
mutianf requested review from a team October 8, 2024 14:01
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Oct 8, 2024
@mutianf
mutianf marked this pull request as draft October 8, 2024 15:32
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 16, 2024
@mutianf
mutianf marked this pull request as ready for review October 16, 2024 13:26
igorbernstein2
igorbernstein2 suggested changes Oct 16, 2024
View reviewed changes

@igorbernstein2 igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, this needs a test :)

Comment thread ...ain/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java
Comment thread ...ain/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java
Comment thread ...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 22, 2024
@mutianf
mutianf force-pushed the factory branch 2 times, most recently from 2ef6d06 to fbb5135 Compare October 22, 2024 16:08
@mutianf
mutianf marked this pull request as draft November 4, 2024 19:01
@mutianf

mutianf commented Nov 4, 2024

Copy link
Copy Markdown
Contributor Author

Note: global otel is not idea. We should refactor how the client context is created so otel doesn't need to be global.

@mutianf
mutianf marked this pull request as ready for review November 26, 2024 22:05
igorbernstein2
igorbernstein2 reviewed Nov 27, 2024
View reviewed changes
Comment thread ...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClientFactory.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated
Comment thread ...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClientFactory.java
igorbernstein2
igorbernstein2 approved these changes Dec 2, 2024
View reviewed changes

@igorbernstein2 igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after comment is addressed

Comment thread ...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java Outdated
@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Dec 2, 2024
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 06b912c into googleapis:main Dec 2, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 2, 2024
@release-please release-please Bot mentioned this pull request Dec 2, 2024
Merged
@mutianf
mutianf deleted the factory branch December 2, 2024 22:32
gcf-merge-on-green Bot pushed a commit that referenced this pull request Dec 4, 2024
@release-please
chore(main): release 2.49.0 (#2431)
28ad9b4 
🤖 I have created a release *beep* *boop*
---


## [2.49.0](https://togithub.com/googleapis/java-bigtable/compare/v2.48.0...v2.49.0) (2024-12-03)


### Features

* Add support for table deletion protection ([#2430](https://togithub.com/googleapis/java-bigtable/issues/2430)) ([687b6df](https://togithub.com/googleapis/java-bigtable/commit/687b6df14b743358e8207cda26022dfc75338d55))


### Bug Fixes

* Allow factory to export to different projects ([#2374](https://togithub.com/googleapis/java-bigtable/issues/2374)) ([06b912c](https://togithub.com/googleapis/java-bigtable/commit/06b912cc5d63436757008e79edfa8286b2ccac18))
* Send priming requests on the channel directly ([#2435](https://togithub.com/googleapis/java-bigtable/issues/2435)) ([b76698d](https://togithub.com/googleapis/java-bigtable/commit/b76698dfb2c8552185f34e01e924ecc80798ba4f))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@release-please release-please Bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mutianf @igorbernstein2