Visitar URL original
fix: send priming requests on the channel directly by mutianf · Pull Request #2435 · googleapis/java-bigtable · GitHub
Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

fix: send priming requests on the channel directly - #2435

Merged
gcf-merge-on-green[bot] merged 15 commits into
googleapis:mainfrom
mutianf:primer
Dec 3, 2024
Merged

fix: send priming requests on the channel directly#2435
gcf-merge-on-green[bot] merged 15 commits into
googleapis:mainfrom
mutianf:primer

Conversation

@mutianf

@mutianf mutianf commented Dec 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Send priming requests on the channel instead of using the stub. This means that we'll not collect metrics on ping and warm requests.

Fixes #2371 ☕️

If you write sample code, please follow the samples format.

@mutianf
mutianf requested review from a team December 2, 2024 14:59
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 2, 2024
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 2, 2024
@mutianf mutianf changed the title fix: channel primer respect other client settings fix: send priming requests on the channel directly Dec 2, 2024
igorbernstein2
igorbernstein2 suggested changes Dec 2, 2024
View reviewed changes
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
@mutianf
mutianf requested a review from a team December 2, 2024 19:32
igorbernstein2
igorbernstein2 suggested changes Dec 2, 2024
View reviewed changes
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
igorbernstein2
igorbernstein2 reviewed Dec 3, 2024
View reviewed changes
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
igorbernstein2
igorbernstein2 reviewed Dec 3, 2024
View reviewed changes
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
igorbernstein2
igorbernstein2 reviewed Dec 3, 2024
View reviewed changes
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Dec 3, 2024
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit b76698d into googleapis:main Dec 3, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 3, 2024
@release-please release-please Bot mentioned this pull request Dec 3, 2024
Merged
@mutianf
mutianf deleted the primer branch December 3, 2024 20:07
gcf-merge-on-green Bot pushed a commit that referenced this pull request Dec 4, 2024
@release-please
chore(main): release 2.49.0 (#2431)
28ad9b4 
🤖 I have created a release *beep* *boop*
---


## [2.49.0](https://togithub.com/googleapis/java-bigtable/compare/v2.48.0...v2.49.0) (2024-12-03)


### Features

* Add support for table deletion protection ([#2430](https://togithub.com/googleapis/java-bigtable/issues/2430)) ([687b6df](https://togithub.com/googleapis/java-bigtable/commit/687b6df14b743358e8207cda26022dfc75338d55))


### Bug Fixes

* Allow factory to export to different projects ([#2374](https://togithub.com/googleapis/java-bigtable/issues/2374)) ([06b912c](https://togithub.com/googleapis/java-bigtable/commit/06b912cc5d63436757008e79edfa8286b2ccac18))
* Send priming requests on the channel directly ([#2435](https://togithub.com/googleapis/java-bigtable/issues/2435)) ([b76698d](https://togithub.com/googleapis/java-bigtable/commit/b76698dfb2c8552185f34e01e924ecc80798ba4f))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@release-please release-please Bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bigtable: Client side metrics opt-out is not honored in BigtableChannelPrimer

2 participants

@mutianf @igorbernstein2