Visitar URL original
feat: Load balancing options for BigtableChannelPool by neilw4 · Pull Request #2667 · googleapis/java-bigtable · GitHub
Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

feat: Load balancing options for BigtableChannelPool - #2667

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:mainfrom
neilw4:load-balancer
Sep 22, 2025
Merged

feat: Load balancing options for BigtableChannelPool#2667
gcf-merge-on-green[bot] merged 2 commits into
googleapis:mainfrom
neilw4:load-balancer

Conversation

@neilw4

@neilw4 neilw4 commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

Experiments have shown that least-in-flight balancing is particularly effective when some channels or backends have problems.

Depends on: #2651

@neilw4
neilw4 requested review from a team September 4, 2025 14:27
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 4, 2025
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Sep 11, 2025
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 11, 2025
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Sep 11, 2025
igorbernstein2
igorbernstein2 reviewed Sep 16, 2025
View reviewed changes
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
igorbernstein2
igorbernstein2 reviewed Sep 16, 2025
View reviewed changes
Comment thread ...-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPoolSettings.java Outdated
igorbernstein2
igorbernstein2 reviewed Sep 16, 2025
View reviewed changes
Comment thread ...-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPoolSettings.java
igorbernstein2
igorbernstein2 reviewed Sep 18, 2025
View reviewed changes

@igorbernstein2 igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Left a couple of nits.

My only outstanding concern is for the least loaded algos. I think we need some protection for channels that are failing fast. So I think we need to track moving error ratios and if ratio crosses some threshold it short circuits least loaded comparison.

Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
Comment thread ...-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPoolSettings.java
igorbernstein2
igorbernstein2 previously approved these changes Sep 19, 2025
View reviewed changes
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2025
neilw4
neilw4 commented Sep 19, 2025
View reviewed changes
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
@igorbernstein2
format
5f403b8 
Change-Id: I6f17513346350b9dc33f0d99407c829721e908e5
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2025
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Sep 22, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2025
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 5adaa84 into googleapis:main Sep 22, 2025
23 of 25 checks passed
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 22, 2025
@release-please release-please Bot mentioned this pull request Sep 24, 2025
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Sep 25, 2025
@release-please
chore(main): release 2.67.0 (#2678)
f546838 
🤖 I have created a release *beep* *boop*
---


## [2.67.0](https://togithub.com/googleapis/java-bigtable/compare/v2.66.0...v2.67.0) (2025-09-24)


### Features

* Idle channel eviction ([#2651](https://togithub.com/googleapis/java-bigtable/issues/2651)) ([70c05c9](https://togithub.com/googleapis/java-bigtable/commit/70c05c9c09a63c53818384d2a66c622c9b95e00e))
* Load balancing options for BigtableChannelPool ([#2667](https://togithub.com/googleapis/java-bigtable/issues/2667)) ([5adaa84](https://togithub.com/googleapis/java-bigtable/commit/5adaa84d80df08779da7c36a50de4632049cfe96))


### Bug Fixes

* Add missing break; to PROTO and ENUM value type check ([#2672](https://togithub.com/googleapis/java-bigtable/issues/2672)) ([337e432](https://togithub.com/googleapis/java-bigtable/commit/337e4325f6cb5d11309ec5f33550d47d97cbe3c3))
* Remove beta api annotation for query paginator ([#2660](https://togithub.com/googleapis/java-bigtable/issues/2660)) ([f68a1fa](https://togithub.com/googleapis/java-bigtable/commit/f68a1fae49b701d1fb9942e2af2fa84a1e5b508a))


### Dependencies

* Update shared dependencies ([#2679](https://togithub.com/googleapis/java-bigtable/issues/2679)) ([a5b8260](https://togithub.com/googleapis/java-bigtable/commit/a5b82609c365ae4792ed822e59039c1a046ef3ff))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@igorbernstein2 igorbernstein2 mentioned this pull request Sep 29, 2025
Merged
@release-please release-please Bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@mutianf mutianf mutianf approved these changes
@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neilw4 @mutianf @igorbernstein2 @yoshi-kokoro