Visitar URL original
feat: support setting ServiceOption for quota project by codyoss · Pull Request #92 · googleapis/java-core · GitHub
Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

feat: support setting ServiceOption for quota project - #92

Merged
codyoss merged 7 commits into
googleapis:masterfrom
codyoss:quota-project
Dec 13, 2019
Merged

feat: support setting ServiceOption for quota project#92
codyoss merged 7 commits into
googleapis:masterfrom
codyoss:quota-project

Conversation

@codyoss

@codyoss codyoss commented Dec 11, 2019

Copy link
Copy Markdown
Member

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2019
@codyoss

codyoss commented Dec 11, 2019

Copy link
Copy Markdown
Member Author

Before this can work two PRs need to be merged and their artifacts released:

Will update this PR after that happens

@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 11, 2019
@codecov

codecov Bot commented Dec 13, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #92 into master will increase coverage by 0.21%.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     66.43%   66.64%   +0.21%     
- Complexity      367      370       +3     
============================================
  Files            34       34              
  Lines          1865     1877      +12     
  Branches        236      240       +4     
============================================
+ Hits           1239     1251      +12     
  Misses          524      524              
  Partials        102      102
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/http/HttpTransportOptions.java 56.94% <100%> (+0.6%) 10 <0> (ø) ⬇️
...src/main/java/com/google/cloud/ServiceOptions.java 44.26% <81.25%> (+2.53%) 33 <3> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4df8f...f53a167. Read the comment docs.

@codyoss codyoss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 13, 2019
@codyoss
codyoss marked this pull request as ready for review December 13, 2019 18:30
@codyoss
codyoss requested a review from a team December 13, 2019 18:31
elharo
elharo reviewed Dec 13, 2019
View reviewed changes
Comment thread google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java Resolved
@codyoss
codyoss requested a review from chingor13 December 13, 2019 21:05
chingor13
chingor13 suggested changes Dec 13, 2019
View reviewed changes

@chingor13 chingor13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small testing nit

Comment thread google-cloud-core/src/test/java/com/google/cloud/ServiceOptionsTest.java Resolved
Comment thread google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java Resolved
@codyoss
codyoss requested a review from chingor13 December 13, 2019 22:59
chingor13
chingor13 suggested changes Dec 13, 2019
View reviewed changes
Comment thread google-cloud-core/src/test/java/com/google/cloud/ServiceOptionsTest.java Resolved
@codyoss
codyoss merged commit 6aa4476 into googleapis:master Dec 13, 2019
@codyoss
codyoss deleted the quota-project branch December 13, 2019 23:37
@release-please release-please Bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@elharo elharo elharo left review comments
@chingor13 chingor13 chingor13 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codyoss @chingor13 @elharo @googlebot