Visitar URL original
feat: support dynamic retry backoff values by daniel-sanche · Pull Request #793 · googleapis/python-api-core · GitHub
Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: support dynamic retry backoff values - #793

Merged
parthea merged 12 commits into
mainfrom
postpone_sleep_generation
Mar 19, 2025
Merged

feat: support dynamic retry backoff values#793
parthea merged 12 commits into
mainfrom
postpone_sleep_generation

Conversation

@daniel-sanche

@daniel-sanche daniel-sanche commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

This PR moves backoff generation until after an rpc is complete and on_error callbacks have been called. This gives the client a chance to change what backoff value is used based on the error details.

This feature is required for Bigtable, where the backend can send retry_info packets to inform the client on how long to wait before a retry

Fixes #792

@daniel-sanche
daniel-sanche requested review from a team February 14, 2025 00:36
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Feb 14, 2025
@daniel-sanche daniel-sanche mentioned this pull request Feb 14, 2025
Closed
@parthea parthea mentioned this pull request Feb 25, 2025
Merged
@parthea parthea mentioned this pull request Mar 12, 2025
Closed
parthea
parthea reviewed Mar 12, 2025
View reviewed changes

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local testing looks good. Test results in googleapis/gapic-generator-python#2359 look good. I'm also waiting for test results in cl/736133031. Once the tests in cl/736133031 pass and we are confident that there won't be an infinite loop ( due to use of while True without another exit condition), we can move forward with this PR.

Comment thread google/api_core/retry/retry_streaming.py Resolved
parthea
parthea reviewed Mar 13, 2025
View reviewed changes
Comment thread google/api_core/retry/retry_base.py Resolved
@parthea
parthea marked this pull request as draft March 17, 2025 13:33
@parthea

parthea commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

I'm going to move this to draft until a regression test is added. Please mark it as ready to review when this PR is ready.

@daniel-sanche
daniel-sanche marked this pull request as ready for review March 17, 2025 23:25
@daniel-sanche

daniel-sanche commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

The tests have been added, so this is ready to review again

@parthea
parthea merged commit 70697a3 into main Mar 19, 2025
@parthea
parthea deleted the postpone_sleep_generation branch March 19, 2025 15:09
@release-please release-please Bot mentioned this pull request Mar 19, 2025
Merged
@release-please release-please Bot mentioned this pull request May 12, 2025
Closed
This was referenced May 30, 2025
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vchudnov-g vchudnov-g Awaiting requested review from vchudnov-g
@ohmayr ohmayr Awaiting requested review from ohmayr
1 more reviewer
@parthea parthea parthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@parthea parthea

@vchudnov-g vchudnov-g

@ohmayr ohmayr

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Retry should generate sleep time after attempt

4 participants

@daniel-sanche @parthea @vchudnov-g @ohmayr