Visitar URL original
Proposal: move API-methods to client · Issue #38 · googleapis/python-storage · GitHub
Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Proposal: move API-methods to client #38

Closed
#311
Closed
Proposal: move API-methods to client#38
#311
Assignees
cojenco
Labels
api: storageIssues related to the googleapis/python-storage API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Description

@tswast
tswast
opened on Apr 22, 2019

The Cloud Storage Python client was one of the first google-cloud-python clients, intended to be more reliable and more Pythonic than the google-api-client that it replaced. It is also a 100% hand-written client. Because it predates the auto-generated google-cloud-python clients, the Cloud Storage Python client has inconsistencies with other google-cloud-python clients.

This design proposal is to bring the Cloud Storage client further into alignment with other google-cloud-python clients and make the eventual inclusion of an auto-generated gRPC transport layer less disruptive to users of the Cloud Storage client.

Design document:

https://docs.google.com/document/d/1A4FIxThZK_enK7OV9ChY54IPrlpbdHwuhvVEu6iTHxM/edit?usp=sharing

Please share your feedback on the specifics of this as comments in the design document.

CC @crwilcox @frankyn @lbristol88

Update: according to comment, we need to update samples for moved methods before deprecating the old ones.

Activity

  1. tswast
    changed the title [-]Storage: redesign proposal[/-] [+]Storage: client redesign proposal[/+] on Apr 22, 2019
  2. IlyaFaer
    self-assigned this
    on Aug 2, 2019
  3. IlyaFaer
    added a commit that references this issue on Nov 8, 2019

    refactor(storage): move 'create_bucket' implementation from 'Bucket' …

    332c8ff
  4. crwilcox
    transferred this issue fromgoogleapis/google-cloud-pythonon Jan 31, 2020
  5. product-auto-label
    added
    api: storageIssues related to the googleapis/python-storage API.
    on Jan 31, 2020
  6. yoshi-automation
    added
    🚨This issue needs some love.
    triage meI really want to be triaged.
    on Feb 3, 2020
  7. busunkim96
    removed
    🚨This issue needs some love.
    triage meI really want to be triaged.
    on Feb 4, 2020
  8. yoshi-automation
    added
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Feb 4, 2020
  9. frankyn
    added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    and removed
    🚨This issue needs some love.
    triage meI really want to be triaged.
    on Feb 4, 2020

  10. frankyn commented on Mar 23, 2020

    @frankyn
    frankyn
    on Mar 23, 2020
    Contributor

    @IlyaFaer I believe this is complete. I'm closing FR.

    If there's something that I missed please reopen.

  11. 234 remaining items

  12. cojenco
    added 12 commits that reference this issue on Oct 13, 2021

    refactor: add / use 'Client._patch_resource' method (googleapis#436)

    620f128

    refactor: add / use 'Client._put_resource' method (googleapis#441)

    b9d4058

    refactor: add / use 'Client._delete_resource' method (googleapis#442)

    c5d2fcb

    refactor: add / use 'Client._post_resource' method (googleapis#443)

    c319578

    refactor: add / use 'Client._list_resource' method (googleapis#446)

    365a305

    refactor: move methods to client class (googleapis#311)

    e0df981

    refactor: add / use 'Client._get_resource' method (googleapis#431)

    7972f9e

    refactor: add / use 'Client._patch_resource' method (googleapis#436)

    fc17300

    refactor: add / use 'Client._put_resource' method (googleapis#441)

    ac168b3

    refactor: add / use 'Client._delete_resource' method (googleapis#442)

    d5880e0

    refactor: add / use 'Client._post_resource' method (googleapis#443)

    2c2cd1b

    refactor: add / use 'Client._list_resource' method (googleapis#446)

    8d62c69

  13. cojenco commented on Aug 10, 2022

    @cojenco
    cojenco
    on Aug 10, 2022
    Contributor

    I believe the refactor is complete through #431 #436 #441 #442 #443 #446

  14. cojenco
    closed this as completedon Aug 10, 2022
  15. frankyn
    assigned
    cojenco
    on Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the googleapis/python-storage API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions